clean up and document nsStyleContext/nsRuleNode

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

I already checked in a bunch of comments, but there's a little bit of code
cleanup that I want to do in nsStyleContext and nsRuleNode as well (make
mRuleNode const, and remove GetStyleBits).

I'll attach a patch for review that includes what I already checked in and some
things that I haven't checked in yet.
Created attachment 173411 [details] [diff] [review]
patch
Attachment #173411 - Flags: superreview?(bzbarsky)
Attachment #173411 - Flags: review?(bzbarsky)
Created attachment 173412 [details] [diff] [review]
patch (only parts that aren't checked in)
Comment on attachment 173411 [details] [diff] [review]
patch

>Index: nsStyleContext.h
>+ * the data in an
>+ * nsStyleContext are also immutable.

Modulo GetUniqueStyleData.  I just looked, though, and both the remaining
callers can probably be eliminated in the 1.9 timeframe if we want.  So I'm ok
with not documenting it and just removing it ASAP....

r+sr=bzbarsky.	Thanks for documenting this!
Attachment #173411 - Flags: superreview?(bzbarsky)
Attachment #173411 - Flags: superreview+
Attachment #173411 - Flags: review?(bzbarsky)
Attachment #173411 - Flags: review+
Checked in to trunk, 2005-02-04 21:24 -0800.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.