281113 - clean up and document nsStyleContext/nsRuleNode

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I already checked in a bunch of comments, but there's a little bit of code
cleanup that I want to do in nsStyleContext and nsRuleNode as well (make
mRuleNode const, and remove GetStyleBits).

I'll attach a patch for review that includes what I already checked in and some
things that I haven't checked in yet.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (only parts that aren't checked in)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 173411 [details] [diff] [review]
patch

>Index: nsStyleContext.h
>+ * the data in an
>+ * nsStyleContext are also immutable.

Modulo GetUniqueStyleData.  I just looked, though, and both the remaining
callers can probably be eliminated in the 1.9 timeframe if we want.  So I'm ok
with not documenting it and just removing it ASAP....

r+sr=bzbarsky.	Thanks for documenting this!

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk, 2005-02-04 21:24 -0800.