281140 - replace getpass() with something that supports <8 chars for "-w -" prompts in CLUs

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[Ulf Weltman]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041231 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041231 Firefox/1.0

common.c uses getpass() for non-Win32 and non-Solaris to prompt for password
when using the "-w -" option.  This is an obsolescent interface on HP-UX because
it supports only up to 8 character passwords.

Reproducible: Always

Steps to Reproduce:
1. ldapsearch -s base -b "" -D "uid=testguy,dc=example,dc=com" -w - "objectclass=*"
2. Enter bind password: testtesttest
Actual Results:  
ldap_simple_bind: Invalid credentials

Expected Results:  
LDAP_SUCCESS

Comment 1

[Ulf Weltman]

Attachment: Diff on common.c for new HP-UX password prompt

Diff on common.c for new HP-UX password prompt

Comment 2

[Rich Megginson]

The fix looks good and builds and runs on RHEL3.  I don't yet have access to an
HP machine for building.

Comment 3

[Rich Megginson]

Tested on HP-UX 11.11 64 bit.  Works fine.  So, can I go ahead a check this in?
  Do we need another review?

Comment 4

[Mark Smith [:mcs]]

The code looks OK to me; please check in.  My only complaint is that it is a lot
of code to include inline inside an #ifdef (imagine if we had similar code for a
bunch of other platforms).  But we can address when someone proposes adding code
for another platform....

Comment 5

[Rich Megginson]

Fixed.

The getpass() function on HP-UX only allows 8 characters.
Since there is not (yet?) a better function, this fix
allows up to 256 character passwords using the raw
tty interfaces for no echo.

David, you can close out this bug or reassign to me for closure.