Closed Bug 281165 Opened 20 years ago Closed 20 years ago

getSelectedItem selects wrong property because of typo

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mcsmurf, Assigned: mcsmurf)

References

()

Details

Attachments

(1 file, 3 obsolete files)

While browsing through some source, i came across this line:
277     return tree.contentView.getItemAtIndex(tree.curentIndex);

I'm quite sure this should be currentIndex (and not curentIndex), also i don't
know if this coding error here has broken anything (that code has been there for
almost 3 years now).
Attached patch Patch (obsolete) — Splinter Review
Fixes bug and includes some whitespace changes
Attached patch Patch 2 (diff -uw) (obsolete) — Splinter Review
Improved wording so now it is clear what target is, etc.
Attachment #173464 - Attachment is obsolete: true
Attached patch Patch 3 (diff -uw) (obsolete) — Splinter Review
forgot to save :/
Attachment #173484 - Attachment is obsolete: true
Attachment #173485 - Flags: review?(timeless)
Attachment #173485 - Attachment is obsolete: true
Attachment #173485 - Flags: review?(timeless)
Attachment #173495 - Flags: review?(timeless)
Comment on attachment 173495 [details] [diff] [review]
Patch v4 (diff -uw)

we really need some localization notes, e.g., is "target" localizable, if so
what needs to be synced?
Attachment #173495 - Flags: review?(timeless) → review+
Attachment #173495 - Flags: superreview?(bzbarsky)
Comment on attachment 173495 [details] [diff] [review]
Patch v4 (diff -uw)

sr=bzbarsky.  Please let me know if this needs checking in.
Attachment #173495 - Flags: superreview?(bzbarsky) → superreview+
Patch checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Summary: Possible bug in DOMI in getSelectedItem() → getSelectedItem selects wrong property because of typo
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: