281172 - DCC longs for its own preferences

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

We've had DCC stuff for a while now, but we still don't actually have any
preferences for it! The most important one being DCC Chat, and the charset thereof.

Stuff coming up.

Comment 1

[:Gijs (he/him)]

*** Bug 290076 has been marked as a duplicate of this bug. ***

Comment 2

[:Gijs (he/him)]

Attachment: Patch to add charset and logging preferences to dcc chats.

Patch again taken from cz 0.9.68.2. More fixes may follow.

Note that there is hardly any interface to change these preferences (bad).
I smell a deja-vu easy fix for cmdPref (I did a similar fix for my first ever
patch for CZ to get people to access plugin prefs). That's something for
another followup patch. I'm obsoleting the half-done patch on the tracker bug
because it's superseded by this one.

Again, work done by Silver.

Comment 3

[:Gijs (he/him)]

Attachment: Fix leftover stuff from SI units

Oops. Mixing two patches = bad.

Fixing.

Comment 4

[:Gijs (he/him)]

Attachment: Add another pref, make them accessible using the pref window, fix MaxLines to actually work

A new thing! :-D

In 0.9.68.3 (and above) this pref doesn't actually work - it changes
CIRCDCCUser.prototype, while it should be changing CIRCDCCChat and
CIRCDCCFileTransfer. Fixed in this patch. Will be fixed in 0.9.68.6, probably
:-)

There's one more small fix to unbreak the preference window, or something
(there'd prolly be some (small) bugs without the empty constructor)

Comment 5

[:Gijs (he/him)]

Attachment: [checked in] Previous patch + more empty constructors and static.js sourced in config.xul

Apologies for bugspam and repetitive review requests.

Samuel: only additions are the fact that it once again works against trunk, if
everything went ok (conference mode broke the previous patch), some additional
empty constructors, and static.js being sourced from the options window. (now
possible with all those extra empty constructors).

Tested this patch with current trunk, no js errors opening ChatZilla or the
pref panel, and still no errors after closing the pref panel. So everything
seems to work just fine :-)

Comment 6

[James Ross]

Checked in --> FIXED (hopefully).

Comment 7

[:Gijs (he/him)]

Ugh. Patch breaks dcc-send. Bad me!

in handlers.js, CIRCDCCFileTransfer.prototype.onInit needs to lose
this.prefs = client.prefs

That's the very least that needs fixing, if it ain't more.

Comment 8

[:Gijs (he/him)]

Attachment: Patch to fix bustage

Patch to fix bustage. tH (Robert Marshall) tested commenting out this line, and sent me a file succesfully. I'm assuming for now that *this bug* is then fixed, at least for now.

Comment 9

[James Ross]

Comment on attachment 204875 [details] [diff] [review]
Patch to fix bustage

r=silver

Comment 10

[James Ross]

Checked in --> FIXED.