281216 - Sunbird won't change the week start date to monday on little calender top left

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[jon power]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Sunbird 0.2

I chose the option to have my week start on Monday. This worked in the main
window for the diary, but in the little window top left showing
Calender/Calenders, it still starts Sunday. This confuses me and I want all my
weeks to start Monday.

Reproducible: Always

Steps to Reproduce:
1.Start Sunbird
2.Choose Tools/options/Views
3.Change First day of The Week to Monday, select OK
4. Look at little Calender top left, no change there!

Actual Results:  
It didn't change.

Expected Results:  
The Calender should start on monday to match the main diary.

Comment 1

[gekacheka]

Workaround:  restart sunbird

--> minor

Comment 2

[Joey Minta]

Attachment: allow multiple refreshDisplay calls

refreshDisplay() is pretty useless right now, since it won't do anything once
the miniMonth has been created.  This allows refreshDisplay to actually do what
its name says.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 192376 [details] [diff] [review]
allow multiple refreshDisplay calls

Part of refreshDisplay really only needs to be ran once, like setting
kMonthList etc. Can you move those to the constructor?
Also, please fix the indenting in refreshDisplay.

Comment 4

[Joey Minta]

Attachment: allow multiple refreshDisplay calls v2

Moves the references setup to the constructor and fixes the indenting.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 193397 [details] [diff] [review]
allow multiple refreshDisplay calls v2

>+              var pref =  Components.classes[
>+                "@mozilla.org/preferences-service;1"
>+              ].getService(Components.interfaces.nsIPrefBranch);
style nit: I prefer
	      var pref = 
Components.classes["@mozilla.org/preferences-service;1"]
				   
.getService(Components.interfaces.nsIPrefBranch);

r=mvl

Comment 6

[Joey Minta]

Patch checked in.

Comment 7

[Joey Minta]

(In reply to comment #5)

> style nit: I prefer
> 	      var pref = 
> Components.classes["@mozilla.org/preferences-service;1"]
> 				   
> .getService(Components.interfaces.nsIPrefBranch);

This would make the line >80 chars.

Comment 8

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!