Closed Bug 281249 Opened 20 years ago Closed 20 years ago

define for CCMAP_ALU_MASK is wrong

Categories

(Core :: Internationalization, defect)

PowerPC
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 obsolete file)

/Users/timeless/mozilla/intl/unicharutil/util/nsCompressedCharMap.cpp: In 
   member function `void nsCompressedCharMap::SetChars(short unsigned int, 
   PRUint32*)':
/Users/timeless/mozilla/intl/unicharutil/util/nsCompressedCharMap.cpp:364:
warning: left
   shift count >= width of type
/Users/timeless/mozilla/intl/unicharutil/util/nsCompressedCharMap.cpp:398:
warning: left
   shift count >= width of type

the line that causes the warning is:
else if (aPage[i] == (((PRUint32)1 << ((1L<<(5)))) - 1))
/intl/unicharutil/util/nsCompressedCharMap.h, line 293 -- #define
CCMAP_BITS_PER_ALU CCMAP_POW2(CCMAP_BITS_PER_ALU_LOG2) 
/intl/unicharutil/util/nsCompressedCharMap.h, line 299 -- #define CCMAP_ALU_MASK
PR_BITMASK(CCMAP_BITS_PER_ALU)

it should be #define CCMAP_ALU_MASK PR_BITMASK(CCMAP_BITS_PER_ALU_LOG2)
Attached patch fix definition (obsolete) — Splinter Review
Attachment #173523 - Flags: superreview?(roc)
Attachment #173523 - Flags: review?(smontagu)
Attachment #173523 - Flags: review?(smontagu) → review+
Attachment #173523 - Flags: superreview?(roc) → superreview+
Comment on attachment 173523 [details] [diff] [review]
fix definition

mozilla/intl/unicharutil/util/nsCompressedCharMap.h	1.23
Attachment #173523 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: