281252 - Disable conversion to 7bit on request

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Patrick Brunschwig]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

RFC 3156 (PGP/MIME) requires all text parts to be either 7bit ASCII or
quoted-printable. Furhtermore, trailing whitespaces have to be escaped.
Currently all messages are automatically converted to 7bit if possible, ie.
there is no way, Enigmail could request 8bit (or QP) encoding in order to comply
with standards.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Patrick Brunschwig]

Attachment: Proposed patch for Mozilla 1.8a

Patch that adds a new field (ForceCharSetEncoding) to nsIMsgCompFields and
corresponding handling.

Comment 2

[Scott MacGregor]

Comment on attachment 173526 [details] [diff] [review]
Proposed patch for Mozilla 1.8a

this seems reasonable to me. I wonder about he name force charset encoding.
When I think charset encoding I'm thinking "use a force charset on this
message" which we already have in other parts of the app.

i.e. view a message, then  change the charset on it, that's what appling a
forced charset means to me.

Comment 3

[David :Bienvenu]

quoted printable causes lots of problems. Is Enigmail planning on forcing quoted
printable?

Comment 4

[David :Bienvenu]

Comment on attachment 173526 [details] [diff] [review]
Proposed patch for Mozilla 1.8a

the patch looks ok, like Scott said, but the name of the method doesn't seem
quite right - maybe ForceMsgEncoding? And as I said before, quoted printable
just wrecks havoc with attachments.

Comment 5

[Patrick Brunschwig]

Attachment: Updated patch, renamed methods to ForceMsgEncoding

Unfortunately, you're forced to use quoted-printable when using PGP/MIME signed
messages if you want to be compliant to RFC 3156 and RFC 2440. So, I don't have
too much choice ...

Comment 6

[chris hofmann]

Comment on attachment 180466 [details] [diff] [review]
Updated patch, renamed methods to ForceMsgEncoding

a=chofmann

Comment 7

[Patrick Brunschwig]

Scott/David, can one of you check in the code? I don't have write access to CVS.

Comment 8

[David :Bienvenu]

           if (NS_SUCCEEDED(rv)) 
           {
+            if (m_compFields->GetForceMsgEncoding());
+              isAsciiOnly = PR_FALSE;
+              

this doesn't look right - the ; makes it so we won't set isAsciiOnly to false. I
assume this is a typo?

Comment 9

[Patrick Brunschwig]

yes, this is definitely a typo. Thanks for spotting this one!

Comment 10

[David :Bienvenu]

Attachment: fix for typo

Comment 11

[David :Bienvenu]

fix for typo checked in.