Disable conversion to 7bit on request

RESOLVED FIXED in Thunderbird1.1

Status

Thunderbird
General
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Patrick Brunschwig, Assigned: Scott MacGregor)

Tracking

unspecified
Thunderbird1.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

RFC 3156 (PGP/MIME) requires all text parts to be either 7bit ASCII or
quoted-printable. Furhtermore, trailing whitespaces have to be escaped.
Currently all messages are automatically converted to 7bit if possible, ie.
there is no way, Enigmail could request 8bit (or QP) encoding in order to comply
with standards.

Reproducible: Always

Steps to Reproduce:
(Reporter)

Comment 1

13 years ago
Created attachment 173526 [details] [diff] [review]
Proposed patch for Mozilla 1.8a

Patch that adds a new field (ForceCharSetEncoding) to nsIMsgCompFields and
corresponding handling.
(Reporter)

Updated

13 years ago
Attachment #173526 - Flags: review?(mscott)
(Assignee)

Comment 2

13 years ago
Comment on attachment 173526 [details] [diff] [review]
Proposed patch for Mozilla 1.8a

this seems reasonable to me. I wonder about he name force charset encoding.
When I think charset encoding I'm thinking "use a force charset on this
message" which we already have in other parts of the app.

i.e. view a message, then  change the charset on it, that's what appling a
forced charset means to me.
Attachment #173526 - Flags: superreview?(bienvenu)

Comment 3

13 years ago
quoted printable causes lots of problems. Is Enigmail planning on forcing quoted
printable?

Comment 4

13 years ago
Comment on attachment 173526 [details] [diff] [review]
Proposed patch for Mozilla 1.8a

the patch looks ok, like Scott said, but the name of the method doesn't seem
quite right - maybe ForceMsgEncoding? And as I said before, quoted printable
just wrecks havoc with attachments.
(Reporter)

Comment 5

13 years ago
Created attachment 180466 [details] [diff] [review]
Updated patch, renamed methods to ForceMsgEncoding

Unfortunately, you're forced to use quoted-printable when using PGP/MIME signed
messages if you want to be compliant to RFC 3156 and RFC 2440. So, I don't have
too much choice ...
Attachment #173526 - Attachment is obsolete: true
(Reporter)

Updated

13 years ago
Attachment #173526 - Flags: superreview?(bienvenu)
Attachment #173526 - Flags: review?(mscott)
(Reporter)

Updated

13 years ago
Attachment #180466 - Flags: superreview?(bienvenu)
Attachment #180466 - Flags: review?(mscott)

Updated

13 years ago
Attachment #180466 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Updated

13 years ago
Attachment #180466 - Flags: review?(mscott)
Attachment #180466 - Flags: review+
Attachment #180466 - Flags: approval-aviary1.1a?

Comment 6

13 years ago
Comment on attachment 180466 [details] [diff] [review]
Updated patch, renamed methods to ForceMsgEncoding

a=chofmann
Attachment #180466 - Flags: approval-aviary1.1a? → approval-aviary1.1a+
(Reporter)

Comment 7

13 years ago
Scott/David, can one of you check in the code? I don't have write access to CVS.
(Assignee)

Updated

13 years ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird1.1

Comment 8

13 years ago
           if (NS_SUCCEEDED(rv)) 
           {
+            if (m_compFields->GetForceMsgEncoding());
+              isAsciiOnly = PR_FALSE;
+              

this doesn't look right - the ; makes it so we won't set isAsciiOnly to false. I
assume this is a typo?
(Reporter)

Comment 9

13 years ago
yes, this is definitely a typo. Thanks for spotting this one!

Comment 10

13 years ago
Created attachment 185683 [details] [diff] [review]
fix for typo
Attachment #185683 - Flags: superreview?(mscott)
(Assignee)

Updated

13 years ago
Attachment #185683 - Flags: superreview?(mscott) → superreview+

Updated

13 years ago
Attachment #185683 - Flags: approval-aviary1.1a2?

Updated

13 years ago
Attachment #185683 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+

Comment 11

13 years ago
fix for typo checked in.
You need to log in before you can comment on or make changes to this bug.