281263 - Remove white text on active tab/column and "jumping" icons in Classic

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

The Classic theme contains some ancient styles, not coherent with OS X:

Text in active Tabs and columns is white.
Icons, like column-picker and drop-down-markers "jumps" when clicked on.

Comment 1

[Stefan [:stefanh]]

Attachment: Fix for white text and jumping icons

Comment 2

[Asaf Romano (gone)]

Comment on attachment 173535 [details] [diff] [review]
Fix for white text and jumping icons

r=me, those rules have no place in OS X.

Comment 3

[Asaf Romano (gone)]

We should also remove most of the :hover:active style rules from the mac classic
theme (e.g. toolbarbutton elements).

Comment 4

[Stefan [:stefanh]]

Comment on attachment 173535 [details] [diff] [review]
Fix for white text and jumping icons

Neil, can you sr/rs this small patch, please?

Comment 5

[[e-mail]]

Does this still work if you put
* { -moz-appearance: none !important; }
in your userChrome.css?

Comment 6

[Stefan [:stefanh]]

Comment on attachment 173535 [details] [diff] [review]
Fix for white text and jumping icons

Talked to Neil on irc and he thought the tree changes looked wrong, so I'll
look into this more later on. Will attach another patch that also covers the
toolbarbuttons.

Comment 7

[Stefan [:stefanh]]

Neil, just a side-note:

I wonder if the changes made in bug 257280 have made inactive menu-buttons move
on hover:active. In the mac classic theme the the dropmarker area gets a dark
background as well. I see this in a build from 041213, but the 041204 build
seems ok.

Comment 8

[[e-mail]]

It shouldn't do, it was just a string change from [buttonover="true"] to :hover
- the numerous [disabled="true"] rules should take care of everything.

Comment 9

[Stefan [:stefanh]]

Attachment: patch for testing

Here's a test-patch to show how it will look. To make it work for "real" a mac
directory in '/communicator' with two new files (button.css and
tasksOverlay.css) and some ifdefs in jar.mn  has to be added.

This patch will do the following:

Remove all hover:active white text (tabs, columns, buttons)
Remove all kinds of hover:active 'jumping' (columns, dropmarker, buttons)
It will also fix some current mac classic hover:active issues (inactive button
'jumping', button history dropmarker area have background-color #666666).

I do wonder if we should remove the hover:active white text on the buttons,
though. Since they now get a dark grey background-color it might be hard to
read the text. But since I think we should remove the white text from the tabs
and columns it might be a bit inconsistent to not remove it from the buttons...
One could of course change the :hover:active background-color on the buttons to
a lighter grey, but then all the borders have to be changed as well... And I'm
not sure it will look nice either. Hmmm...

Mano, any thoughts? Shall we keep the white text? Is the idea of removing all
the hover:active 'jumping' good or shall we keep that on the buttons?

Comment 10

[Stefan [:stefanh]]

Attachment: Fix for tabs/columns & icons/dropdown (Checked in)

This patch is basically the same as the original one apart from correcting the
issues in tree.css that Neil mentioned and a few other nits. I haven't done
anything with the buttons, though. If that should be fixed, I'll open another
bug for that. Not sure if a fix for the buttons is desirable. A fix for the
buttons will most likely need new file(s) in a communicator/mac folder.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 179392 [details] [diff] [review]
Fix for tabs/columns & icons/dropdown (Checked in)

r=[e-mail]

Comment 12

[[e-mail]]

Comment on attachment 179392 [details] [diff] [review]
Fix for tabs/columns & icons/dropdown (Checked in)

> /* when a tab is selected this is how it should look */
>-tab[selected="true"]:hover:active {
>-	color			: #000000;
>-}
> 
Nit: this line could have gone too, as it happens, but never mind.

Comment 13

[Stefan [:stefanh]]

Attachment: Correct version, carrying over flags

Couldn't help fixing Neils nit. Carrying over flags and requesting approval
1.8b2. Simple fix that removes some non-OS X:ish styles in classic theme.

Comment 14

[Stefan [:stefanh]]

Comment on attachment 181313 [details] [diff] [review]
Correct version, carrying over flags

Agh, got it completely wrong here

Comment 15

[Stefan [:stefanh]]

Comment on attachment 179392 [details] [diff] [review]
Fix for tabs/columns & icons/dropdown (Checked in)

OK, nevermind...

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 179392 [details] [diff] [review]
Fix for tabs/columns & icons/dropdown (Checked in)

a=asa

Comment 17

[Ian Neal]

Comment on attachment 179392 [details] [diff] [review]
Fix for tabs/columns & icons/dropdown (Checked in)

Checking in autocomplete.css;
/cvsroot/mozilla/themes/classic/global/mac/autocomplete.css,v  <-- 
autocomplete.css
new revision: 1.12; previous revision: 1.11
done
Checking in tabbox.css;
/cvsroot/mozilla/themes/classic/global/mac/tabbox.css,v  <--  tabbox.css
new revision: 1.8; previous revision: 1.7
done
Checking in tree.css;
/cvsroot/mozilla/themes/classic/global/mac/tree.css,v  <--  tree.css
new revision: 1.30; previous revision: 1.29
done

Comment 18

[Stefan [:stefanh]]

--> Fixed