281272 - Sort By Name broken in Bookmarks Manager.

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Steve Aronoff]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Sorting bookmarks by name in bookmark manager doesn't sort them in the browser.

Reproducible: Always

Steps to Reproduce:
1. Go to Bookmarks Manager and sort a folder or all by name
2. Go to Bookmarks in the browser and open the folder

Actual Results:  
The bookmarks weren't sorted by name.

Expected Results:  
Sort the bookmarks by name.

Comment 1

[Cyriel van 't End]

Could reproduce this with the following steps:

1. Open Bookmark Manager
2. Open a folder
3. Right click on the folder
4. Select Sort By Name

Result: Bookmarks are not sorted

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5)
Gecko/20041107 Firefox/1.0

Comment 2

[Mike Connor [:mconnor]]

Fix or disable this.

Comment 3

[Mike Connor [:mconnor]]

hmm, I don't know why I resolved this.

Comment 4

[Ben Fowler]

(In reply to comment #0)
 
> Sorting bookmarks by name in bookmark manager doesn't sort them 
> in the browser.

I am happy with the current behaviour. Sorting in the manager should
be temporary to enable similar irems to be grouped and compared
before deletion or moving. It should not affect the display in the
sidebar (sortable and searchable independently) or in the menu. 
The menu should be arrnged spatially (unsorted) - which is the
closest we can easily get to sorted by topic (and I would prefer
most recently added to to be on top, but that it another matter).

Comment 5

[Ben Fowler]

(In reply to comment #1)
> 1. Open Bookmark Manager
> 2. Open a folder
> 3. Right click on the folder
> 4. Select Sort By Name
> 
> Result: Bookmarks are not sorted

Step 3 is: right click on any item in the open folder (the
right hand pane) - the menu has a sort item which is
ineffective.

I would guess that this is unrelated to comment 0. If the item is
to be present, and whilst a close call, it should be; then it should
work. 

Kindly note that another UI glitch is that when the Bookmarks
manager comes up, the View Application Menu often has a checkmark
against both the Unsorted and Sorted By Name items.

Comment 6

[David G King]

Changing to "NEW" due to blocking status.

Comment 7

[Jason Gallagher]

(In reply to Comment #5)

>(In reply to comment #1)
>> 1. Open Bookmark Manager
>> 2. Open a folder
>> 3. Right click on the folder
>> 4. Select Sort By Name
>> 
>> Result: Bookmarks are not sorted

>Step 3 is: right click on any item in the open folder (the
>right hand pane) - the menu has a sort item which is
>ineffective.

>I would guess that this is unrelated to comment 0. If the item is
>to be present, and whilst a close call, it should be; then it should
>work. 

It seems to me that the original bug poster was refering to Step 3 in Comment
#1.  I say this because if you go by the explanation "sorting bookmarks by name
in bookmark manager doesn't sort them in the browser" then you can not duplicate
this, because in Firefox 1.0.4 (presumably having the same bookmark behavior as
Firefox 1.0) if you sort bookmarks in bookmark manager the changes do appear in
the browser bookmarks pulldown menu.  In that case you would have to mark this
bug worksforme.

However, if the expected behavior is that when you click on a folder and choose
"sort by name" one expects the bookmarks in the folder selected to sort, then
there is a bug.  I suspect, as Comment #1 makes clear in step #3, that this was
the expected behavior.

Even if this was not the actual bug being reported, this should be listed
somewhere as a bug, just like Comment #1 reports.

I have seen some discussion on other bugs about whether bookmarks within folders
and subfolders should sort when choosing "sort by name."  I would like to
clarify that what I think is meant is that when clicking on a folder, bookmarks
in that folder, and that folder only, should sort when choosing "sort by name."
 If "sort by name" is to be strictly defined as sorting the current folder that
the bookmark or folder is within, then a possible compromise is to create a menu
option called "sort folder by name" that occurs only when the user right clicks
on a folder in their bookmarks list.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Hrm.  There are two potential bugs here:

One is the issue described in comment #7:

In the bookmarks manager, doing a right-click sort-by-name on any item results
in the toplevel bookmarks being sorted (or whatever folder is selected in the
left pane or being "managed"), instead of sorting the contents of a target
folder.  This is a real bug, but I vaguely remember it being hard to fix because
of some reason or another.  I'll look into it.

The other is:

Selecting View -> Sorted by XXX just changes the sort order in the bookmarks
manager, and doesn't actually move the bookmarks around.  This is actually an
older bug (can't find bug# atm), and isn't really a bug.. the View menu isn't
really tied to the actual order of the bookmarks, just the display.  This sucks,
but is near impossible to fix with the current bookmarks setup.

Comment 9

[Peter van der Woude [:Peter6]]

*** Bug 308345 has been marked as a duplicate of this bug. ***

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Which part of this is blocking 1.8b5?  The sort-target stuff is relatively
minor, and the View menu "Sort by Name" stuff is INVALID/WONTFIX.  This probably
should be -'d for 1.8.

Comment 11

[Piero Rocca]

I'm seeing this as well.

Comment 12

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 13

[Hussam Al-Tayeb]

Is this still an issue?

Comment 14

[Raymond Martineau]

Works for me (Firefox 2.0, which is the latest version that uses this type of bookmark system.) 

I think we can resolve/close it.  

Comment 15

[Marco Bonardo [:mak]]

Sort by name in the context menu works fine, so this is WFM.
In case anyone is looking for ordering choosen in organizer being persistent you should move to bug 363042.