Closed Bug 281273 Opened 20 years ago Closed 18 years ago

Deleting an author strands addons

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED DUPLICATE of bug 324671

People

(Reporter: peter, Assigned: Bugzilla-alanjstrBugs)

References

(
URL
)

Details

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Warning: Invalid argument supplied for foreach() in
/opt/update/themes/showlist.php on line 343


Reproducible: Always

Steps to Reproduce:
1. open the url
https://update.mozilla.org/themes/showlist.php?application=firefox&version=1.0&os=Windows&category=Miscellaneous&numpg=10&pageid=4
2.
3.
Confirming bug, I had a scout around for a Duplicate, but couldn't find one. 

The problem seems to be that
https://update.mozilla.org/themes/moreinfo.php?application=firefox&version=1.0&os=Windows&category=Miscellaneous&numpg=10&id=266
has no author.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: PHP Warnings after third theme → PHP Warnings after third theme
Summary: PHP Warnings after third theme → PHP Warnings on showlist.php when there is no author for a theme/extension
(In reply to comment #1)
> Confirming bug, I had a scout around for a Duplicate, but couldn't find one. 
> 
> The problem seems to be that
>
https://update.mozilla.org/themes/moreinfo.php?application=firefox&version=1.0&os=Windows&category=Miscellaneous&numpg=10&id=266
> has no author.
> 

We should check before the foreach if the $authors is empty, or use a regular

for($idx=0; $idx<$authorcount; $idx++)

instead, at line 343



The root cause is bug 279792.  When I deleted the author, it didn't delete his
themes.  Our code shouldn't need to worry about moreinfo and showlist, it should
be in the author delete.  If the author is gone and is the only contributor, the
addon should be deleted too.
Symptom fixed from bug 279792.  Changing summary to reflect root cause.
OS: Windows Server 2003 → All
Summary: PHP Warnings on showlist.php when there is no author for a theme/extension → Deleting an author strands addons
Target Milestone: 1.0 → 1.1
Severity: normal → major
Target Milestone: 1.1 → 2.0

*** This bug has been marked as a duplicate of 324671 ***
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.