281286 - Remove nsIPref usage from OJI

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect)

Description

[Vidar Haarr (not reading bugmail)]

nsIPref is deprecated, we should use nsIPrefBranch.

First patch in a couple of minutes.

Comment 1

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.1

There could be a problem with initial value (on construction), but I'm not
sure.

Comment 2

[Vidar Haarr (not reading bugmail)]

Comment on attachment 173556 [details] [diff] [review]
version 0.1

I'll wait for r before asking sr. Oh, and I noticed
"-    "
"+   ",
I'll fix that after review.

Comment 3

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.2 (Checked in)

Updated per timeless' comments on IRC.

Comment 4

[Ian Neal]

Comment on attachment 173670 [details] [diff] [review]
version 0.2 (Checked in)

Checking in nsJVMManager.h;
/cvsroot/mozilla/modules/oji/src/nsJVMManager.h,v  <--	nsJVMManager.h
new revision: 1.23; previous revision: 1.22
done
Checking in nsJVMManager.cpp;
/cvsroot/mozilla/modules/oji/src/nsJVMManager.cpp,v  <--  nsJVMManager.cpp
new revision: 1.72; previous revision: 1.71
done

Comment 5

[Vidar Haarr (not reading bugmail)]

Thanks for the reviews and checkin!
FIXED.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using the 2005-02-10-05 build and LXR (for code inspection) on
Windows XP, Seamonkey trunk.