281322 - Minimo should use the newer nsIPrefService APIs instead of nsIPref

Status: RESOLVED WONTFIX

(Minimo Graveyard :: General, defect)

Description

[Vidar Haarr (not reading bugmail)]

Rid the source of nsIPref!

Comment 1

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.1

I found this code quite strange, with all the do_CreateInstance.

Comment 2

[Mikael Parknert]

+  nsCOMPtr<nsIPrefBranch> pref = do_GetService(NS_PREF_CONTRACTID);

use should use NS_PREFSERVICE_CONTRACTID for the new nsIPrefService-interfaces

Comment 3

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.2

That's what you get for not compiling :P
I don't know how to build Minimo, but if someone tells me, I'll do that.

In any case, the bug was more for bugging dougt about doing do_CreateInstance
:)

Comment 4

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.3

heh, forgot a do_CreateInstance

Comment 5

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.4

updated to fix bitrot

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 195020 [details] [diff] [review]
version 0.4

looks fine.

Comment 7

[Vidar Haarr (not reading bugmail)]

I just found
<http://lxr.mozilla.org/mozilla/source/embedding/minimo/app/mozilla_api.cpp#260>,
which needs to be fixed as well, but I'm not quite sure what needs to be done there.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #7)
> <http://lxr.mozilla.org/mozilla/source/embedding/minimo/app/mozilla_api.cpp#260>,
> which needs to be fixed as well, but I'm not quite sure what needs to be done
there.

what needs fixing there?

Comment 9

[Vidar Haarr (not reading bugmail)]

I removed
-#define PREF_ID NS_PREF_CONTRACTID
in attachment 195020 [details] [diff] [review] ...

Problem is I'm not sure if
nsCOMPtr<nsIPrefService> prefService = do_GetService (PREF_ID);
is the right way of getting a pref service or not, but I'm sure you know, biesi :-)
If it is, the fix is simply to switch it for
nsCOMPtr<nsIPrefService> prefService = do_GetService (NS_PREF_CONTRACTID);

(Why the #define PREF_ID NS_PREF_CONTRACTID anyway?)

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

oh. just use do_GetService(NS_PREFSERVICE_CONTRACTID);

Comment 11

[Vidar Haarr (not reading bugmail)]

Attachment: fixes compile error

I've been trying to build Minimo a few times now with different .mozconfigs,
but I keep getting compile errors related to XFT - so I can't really check if
the patch builds :-/

It should be alright now, though. I've grep'ed through the source and PREF_ID
isn't used anywhere else, so there shouldn't be any compile errors.

Comment 12

[Doug Turner (:dougt)]

embedding/minimo/app is deprecated.