281353 - Set maintainer's (default) e-mail address to %maintainer% instead of bugzilla-daemon, bugzilla-admin-daemon or bugzilla-request-daemon

Status: RESOLVED DUPLICATE of bug 135812

(Bugzilla :: Email Notifications, defect)

Description

[Peter Bittner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.5) Gecko/20041122 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.5) Gecko/20041122 Firefox/1.0

The default "templates" for mail messages often still contain "bugzilla-daemon"
in the From: field instead of the %maintainer% variable. This should be fixed!

The following files are affected: (contain 'bugzilla-daemon')

- lib/defparams.pl

Similarly some template files contain 'bugzilla-admin-daemon' or
'bugzilla-request-daemon' hardcoded which (correct me if I am in error) should
be replaced by '[% Param('maintainer') %]'.

The following files are affected: (contain 'bugzilla-admin-daemon' or
'bugzilla-request-daemon')

- template/en/default/account/password/forgotten-password.txt.tmpl
- template/en/default/account/email/change-new.txt.tmpl
- template/en/default/account/email/change-old.txt.tmpl
- template/en/default/account/cancel-token.txt.tmpl
- template/en/default/request/email.txt.tmpl


Reproducible: Always

Steps to Reproduce:
A) Logged in as Bugzilla administrator on an fresh Bugzilla installation go to
"Parameters" and check out the default mail messages.

B) Check the From: address in e-mails sent to you when
- receiving a notification for new bugs (or changes)
- requesting a link for a forgotten password
- cancelling your request for a forgotten password
- (etc.)

Actual Results:  
Invalid e-mail address in From: field of received e-mail.

Expected Results:  
Specify the e-mail address of the Bugzilla maintainer as configured via the
"Parameters" page.

Comment 1

[Max Kanat-Alexander]

Actually, the %maintainer% variable and the bugzilla-daemon address are
different things.

The maintainer is the admin, who appears in "software error" messages.
bugzilla-daemon is the address that sends all Bugzilla mail.

In most installations, I doubt that the maintainer would want to get all of the
bounces from all BugMail. :-)

Comment 2

[Peter Bittner]

(In reply to comment #1)
> Actually, the %maintainer% variable and the bugzilla-daemon address are
> different things.

I suspected this too. However, the From: field (i.e. the sending e-mail address)
should definitely be configurable. For our installation an address of
"bugzilla-daemon" is irritating for the user since the term "Bugzilla" does not
appear in the system's name directly anymore.

Let us introduce a new variable %bugzilla-daemon% (let's do away with
"bugzilla-request-daemon", come on!) which is configurable on "Parameters" page.

> In most installations, I doubt that the maintainer would want to get all of
> the bounces from all BugMail. :-)

But if someone (e.g. of our customers) sends back mail the system should react.
We will either configure an AutoReply or a Public Folder where our Bugzilla
administrator person looks into every now and then.

Comment 3

[Marc Schumann [:Wurblzap]]

So... is this bug's name possibly rather "Make Bugzilla e-mail sender's address
centrally configurable" or "... a parameter" or something, then?

Comment 4

[Peter Bittner]

(In reply to comment #3)
> So... is this bug's name possibly rather "Make Bugzilla e-mail sender's address
> centrally configurable" or "... a parameter" or something, then?

Probably so. But actually the maintainer's address (which *is* centrally
configurable) is used already for sending wine-mails. That's why a summary like
that would not have been fully correct.

Comment 5

[Marc Schumann [:Wurblzap]]

(In reply to comment #4)
> Probably so. But actually the maintainer's address (which *is* centrally
> configurable) is used already for sending wine-mails. That's why a summary like

True. And imo a bug in its own right :)

*** This bug has been marked as a duplicate of 135812 ***