281364 - DB-compatibility layer needs error checking for checksetup purposes

Status: RESOLVED DUPLICATE of bug 281360

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

I'm trying to solve bug 281360 right now, and I'm discovering that if I write
something ridiculous for $db_driver in localconfig, or if I don't have MySQL up
and running, perl gives me a very cryptic error message.

Instead, the error checks and messages that are now in checksetup should be
inside of Bugzilla::DB, in the _connect function.

Basically, just this line needs to change, to test $db_driver:

eval ("require $pkg_module") || die ($@);

And this line in db_new() needs to do some error-catching if we fail to connect
to the database:

my $self = DBI->connect($dsn, $user, $pass, $attributes);

I didn't put this as a comment on bug 237862 because I want that checked-in, and
we can fix this afterwards.

Comment 1

[Max Kanat-Alexander]

Actually, this is so easy I can do it myself.

Comment 2

[Max Kanat-Alexander]

Actually, this is so easy I can do it myself.

Comment 3

[Max Kanat-Alexander]

OK, I actually rolled it into bug 281360.

Comment 4

[Max Kanat-Alexander]

I'll just handle it all in bug 281360.

*** This bug has been marked as a duplicate of 281360 ***