281401 - some Command shortcuts broken, now send messages to Trash

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2005020704-trunk tbird bits on mac os x 10.3.7. when I use some
keyboard shortcuts (accelerators), rather than issuing the proper command, the
selected message is moved to the Trash.

this doesn't seem to affect Command+Shift+shortcuts, like Cmd+Shift+M (new mail
compose) or Cmd+Shift+R (reply all). and some accelerators aren't affected, like
Cmd+O, Cmd+E, Cmd+H, Cmd+M, Cmd+Q, Cmd+L and Cmd+,.

affected shortcuts:

Cmd+R - reply
Cmd+P - print
Cmd+W - close (standalone window)

I'll check if other platforms are also affected.

Comment 1

[sairuh (rarely reading bugmail)]

also affected:

Cmd+A, Cmd+C, Cmd+Z - editing commands
Cmd+F - find
Cmd+T - get new msgs

Comment 2

[Scott MacGregor]

all of these commands result in a move to tash? 

Comment 3

[sairuh (rarely reading bugmail)]

yeah, always moving the selected message to the Trash.

not a problem on Linux fc2 --anyone see this on Windows (methinks it's Mac-only).

getting regression window...

Comment 4

[Scott MacGregor]

windows works fine too, FYI

Comment 5

[sairuh (rarely reading bugmail)]

hm, I thought this would be a recent bug, but it's occurring with
2005013103-trunk tbird bits.

Comment 6

[sairuh (rarely reading bugmail)]

this regressed sometime btwn 2005011504-trunk (works) and 2005012103-trunk
(broken). will get a narrower window later on...

Comment 7

[sairuh (rarely reading bugmail)]

regressed btwn 2005011903-trunk (works) and 2005012004-trunk (broken) builds.

Comment 8

[Scott MacGregor]

hmm I didn't see any suspicous checkins over that time frame other than lots of
xforms work which I'm pretty sure doesn't effect us :)

thanks for narrowing the builds down sarah.

Comment 9

[sairuh (rarely reading bugmail)]

I'll go see if seamonkey is also affected...

Comment 10

[sairuh (rarely reading bugmail)]

hrm, today's mac seamonkey build doesn't exhibit this.

Comment 11

[Scott MacGregor]

maybe this is just deja vu but I feel like this happened before last year. I
wish i could remember what broke that caused it....

Comment 12

[Scott MacGregor]

This bug was caused by Bug #137523. It's suprising that the entity errors for
the keycode bindings introduced by that bug manifested themselves by causing all
key commands to act as cmd_delete.

Comment 13

[Scott MacGregor]

Attachment: the fix, port the entity strings added by Bug #137523

Comment 14

[Scott MacGregor]

fixed

Comment 15

[Asaf Romano (gone)]

Scott, why does tb use this overlay anyway (and don't use it's dtd from xpfe/)
I'm confused.

Comment 16

[Scott MacGregor]

for automated build localization purposes, all of the locale files have been
forked into mozilla\toolkit and mozilla\mail and mozilla\browser. Firefox and
Thunderbird don't leverage any locale files outside of those two directories. 

Comment 17

[Asaf Romano (gone)]

So, aren't there extra minimize/zoom menu items (i don't remember if they have
the same id)? maybe we can drop the thunderbid specific window menu code; I
don't know what is 'right' for thunderbid.

Comment 18

[Kathleen :Brade]

an interesting bug; I wonder if nVu or other apps would have this too?

Comment 19

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to comment #18)

> an interesting bug; I wonder if nVu or other apps would have this too?

Kathy, Nvu is not built on the trunk at this time.

Comment 20

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2005021004-trunk tbird bits on mac os x 10.3.8.