281411 - The "Remaining Time" value should not be negative for too large "Hours Worked" values

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

When the "Hours Worked" field has a value which is larger than the one in the
"Hours Left" field, a negative value is calculated and is then rejected by
ValidateTime().

To treat this case correctly, you only have to set a value of zero instead of a
negative value, see bug/edit.html.tmpl, lines 100-101:

new_time = Math.max(fRemainingTime - document.changeform.work_time.value, 0.0);

Here, I have added Math.max(..., 0.0) so that "new_time" is never negative, as
it should be.

Comment 1

[Frédéric Buclin]

Attachment: trivial patch, v1

prevent negative values for "Hours Left"...

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 173808 [details] [diff] [review]
trivial patch, v1

r=wurblzap by inspection.

>      // subtracts time spent from remaining time
>      var new_time;
> 
>+     // prevent negative values if work_time > fRemainingTime

Nit: it's imho clearer if you merged the two comments, along the lines of
"substract time spent from remaining time; take care not to let that drop below
zero" or something. If you do that, please carry r+ forward.

Comment 3

[Shane H. W. Travis]

Checked in on tip:

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
  edit.html.tmpl
new revision: 1.55; previous revision: 1.54
done

Awaiting a+/a- on 2.18 before resolving.

Comment 4

[Shane H. W. Travis]

Checked in on 2.18.

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
  edit.html.tmpl
new revision: 1.40.2.6; previous revision: 1.40.2.5
done