28144 - Make XP Toolkit widgets look more professional

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[german]

The widgets used in dialogs and other XUL areas are still lacking when compared 
to the spec shown at http://www.mozilla.org/projects/ui/netscape/xpfe_widgets/ . 
This affects especially radio buttons, titledbuttons, checkboxes and select 
widgets. This is filed against hangas since he already has worked on those 
changes and has them locally in his tree. this is also low risk as it affects 
only CSS files. With very low risk we will get a much more professional looking 
product. No extra work is required at this time, we just need to check this in.

Comment 1

[german]

nominating this for beta 1 is this helps really make a big difference once we 
release this product to the general public.

Comment 2

[hangas]

I already have much of the work done, it would have gone in earlier but it had 
been waiting for 24390 to be fixed.  Now that 24390 is out of the way, we can 
make our widgets look like they were intended to look.

Comment 3

[Sjoerd Visscher]

You are not working on the look of the tab widget?

Comment 4

[hangas]

Adding completion date of 2/25

Comment 5

[hangas]

Checked in phase 1 of this effort.  We now have widgets that look like German's 
spec: http://gooey/client/5.0/specs/xpfe_widgets/ This can be tested by verifying 
that the following widgets look like the spec in the default state (hover and 
active states are different from the spec because outline is not available in our 
css): checkbox, radio button, text field, command button (OK/Cancel type), 
popdown menu.  The tab widgets (see New Address Book Card dialog) have been 
updated as well.  They differ from the current spec only because German has not 
brought the spec up to date.

Comment 6

[Paul MacQuiddy]

eli_to_verify_monday

Comment 7

[hangas]

Marking fixed.  Minor changes to corners on widgets. Also changed row height of 
Mail/News thread pane and Address Book results pane, both are now a minimum of 14 
pixels high with a maximum based on the size of the font used.  These panes had a 
height of 18 and 12 respectively before this latest checkin.

Comment 8

[Eli Goldberg]

Left voice mail to German to request that he do the verification, since it
sounds like a definitive specification to compare against isn't available ---
and he's more likely to know on-sight whether it's fixed correctly.

Comment 9

[german]

Partial first checkin has been completed so we were able to do as much as we
could given the fact we learned we will not have the CSS2 outline working(see
bug 29523). This is as much as we can do for XUL widgets for beta1. The work on
this bug is ongoing though and will likely be picked up again for beta 2
Thus nominating this bug for leaving it open, but to remove PDT+ and beta 1
attributes until until we have the support from gecko for a proper second border
attribute which will then be used to draw proper hover and focus appearances.
(see bug 29523). We will then renominate for beta 2

Comment 10

[hangas]

Changing summary, whiteboard, keyword, and milestone to reflex the reopening of 
this bug as a beta2 effort.  Seems like this should have been a new bug so that 
we could have verified that this PDT+ effort was done correctly.

Comment 11

[hangas]

Sending to Ben.

Comment 12

[don]

Move to M16 for now ...

Comment 13

[leger]

Need to know specifically what is still let to do here.

Comment 14

[leger]

Putting on [nsbeta2+][6/01] radar.  PDT will evalate how far we are on this on 
06/01.  Per hangas...work to be done:
"The priority list for beta2 checkins from UI Engineering looks like this: 
- There is an ongoing effort from a number of folks to get the app converted to 
the new xul widgets. 
- Then we need to make the app skinnable; which involves breaking up the current 
css into widget and application styles, and adjusting the styles in the xul and 
css files to accomodate the Theme Swithing that was just turned on. 
- Then we need to land the Classic skin, this is no small task 
- Finally we will work on the widgets for the modern skin. 

This work is happening in parallel but when it comes to priorities the widgets 
will be the first thing to drop off if we are not going to complete this by 
whatever date PDT tells us that we need to stop checking in changes for beta2.  
The date I selected for all of this was 6/15 when I met with PDT."

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

I think this is pretty much done. Open new bugs on any issues that exist. 

Comment 16

[sujay]

John, can you verify this one?

Comment 17

[John Morrison]

marking verified fixed. Open new bugs on any issues that exist.