281470 - Vertical mouse drags are reversed on Google maps

Status: VERIFIED FIXED

(Camino Graveyard :: Page Layout, defect)

Description

[Simon Fraser [no longer active]]

Go to Google maps, and wait for the US map to load. Now click on the map, and
drag side-to-side, and note that it behaves as you expect.

Now drag up and down. Note that the movement is in the opposite direction to
your mouse movement. This does not occur in Firefox.

We must be passing Core Graphics-style mouse coords down into Gecko in the Cocoa
widget layer.

Comment 1

[Mike Pinkerton (not reading bugmail)]

yup, saw that last night, had the same thought.

Comment 2

[Simon Fraser [no longer active]]

Attachment: Fix WidgetToScreen and ScreenToWidget to flip coords

This patch fixses the bug, and does some other cleanup in nsChildView --
removal of unused function, removal of pre-10.2 stuff, and some minor logic
cleanup.

Comment 3

[Simon Fraser [no longer active]]

Taking.

Comment 4

[Mike Pinkerton (not reading bugmail)]

+    {
+      req->GetInterface(NS_GET_IID(nsIScrollableView), (void**)&scrollableView);
+      if (scrollableView)
+        break;
+    }

why do this? the current way is just as clear.

can you make a patch that doesn't do any api clean up for the 083 branch?

r=pink

Comment 5

[Simon Fraser [no longer active]]

Attachment: Minimal patch for the branch

Comment 6

[Simon Fraser [no longer active]]

Comment on attachment 173748 [details] [diff] [review]
Fix WidgetToScreen and ScreenToWidget to flip coords

Checked into the trunk.

Comment 7

[Simon Fraser [no longer active]]

Fixed on trunk.

Comment 8

[Mike Pinkerton (not reading bugmail)]

landed on branch.

Comment 9

[Greg K.]

Might this have also fixed Bug 237788, I wonder? (It rang a bell when I saw it.)

Comment 10

[Simon Fraser [no longer active]]

Bug 237788 has a nice testcase.

Comment 11

[sairuh (rarely reading bugmail)]

verified fixed using 20050212-0.8.3 branch and 2005031008-trunk camino bits.
dragging behaves sensibly now.

changing "fixed1.7.6" to "verified1.7.6" since I tested with the camino branch.

Comment 12

[sairuh (rarely reading bugmail)]

mistakenly removed fixed1.7.6 --pardon the bugspam. set your filter/quicksearch
to "ZippidityDooDahHey" to catch these for easy removal/etc/