Vertical mouse drags are reversed on Google maps

VERIFIED FIXED in Camino0.9

Status

Camino Graveyard
Page Layout
VERIFIED FIXED
13 years ago
13 years ago

People

(Reporter: Simon Fraser, Assigned: Simon Fraser)

Tracking

({fixed1.7.6, verified1.7.6})

unspecified
Camino0.9
PowerPC
All
fixed1.7.6, verified1.7.6

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
Go to Google maps, and wait for the US map to load. Now click on the map, and
drag side-to-side, and note that it behaves as you expect.

Now drag up and down. Note that the movement is in the opposite direction to
your mouse movement. This does not occur in Firefox.

We must be passing Core Graphics-style mouse coords down into Gecko in the Cocoa
widget layer.
yup, saw that last night, had the same thought.
Status: NEW → ASSIGNED
Target Milestone: --- → Camino0.9
(Assignee)

Comment 2

13 years ago
Created attachment 173748 [details] [diff] [review]
Fix WidgetToScreen and ScreenToWidget to flip coords

This patch fixses the bug, and does some other cleanup in nsChildView --
removal of unused function, removal of pre-10.2 stuff, and some minor logic
cleanup.
Attachment #173748 - Flags: review?(pinkerton)
(Assignee)

Comment 3

13 years ago
Taking.
Assignee: pinkerton → sfraser_bugs
Status: ASSIGNED → NEW
+    {
+      req->GetInterface(NS_GET_IID(nsIScrollableView), (void**)&scrollableView);
+      if (scrollableView)
+        break;
+    }

why do this? the current way is just as clear.

can you make a patch that doesn't do any api clean up for the 083 branch?

r=pink
(Assignee)

Comment 5

13 years ago
Created attachment 173753 [details] [diff] [review]
Minimal patch for the branch
(Assignee)

Updated

13 years ago
Blocks: 279168
(Assignee)

Comment 6

13 years ago
Comment on attachment 173748 [details] [diff] [review]
Fix WidgetToScreen and ScreenToWidget to flip coords

Checked into the trunk.
Attachment #173748 - Attachment is obsolete: true
Attachment #173748 - Flags: review?(pinkerton) → review+
(Assignee)

Comment 7

13 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
landed on branch.

Comment 9

13 years ago
Might this have also fixed Bug 237788, I wonder? (It rang a bell when I saw it.)
(Assignee)

Comment 10

13 years ago
Bug 237788 has a nice testcase.
Keywords: fixed1.7.6
verified fixed using 20050212-0.8.3 branch and 2005031008-trunk camino bits.
dragging behaves sensibly now.

changing "fixed1.7.6" to "verified1.7.6" since I tested with the camino branch.
Status: RESOLVED → VERIFIED
Keywords: fixed1.7.6 → verified1.7.6
mistakenly removed fixed1.7.6 --pardon the bugspam. set your filter/quicksearch
to "ZippidityDooDahHey" to catch these for easy removal/etc/
Keywords: fixed1.7.6
You need to log in before you can comment on or make changes to this bug.