281494 - Create Bugzilla::Install::Requirements for requirements-checking subroutines in checksetup.pl

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement, P1)

Description

[Max Kanat-Alexander]

This is a little piece of bug 277502. Basically, I want to move all the
perl-module checking stuff that happens in checksetup into subroutines in a new
module, called Bugzilla::Requirements.

Comment 1

[Frédéric Buclin]

The trunk is now frozen to prepare Bugzilla 2.22. Enhancement bugs are retargetted to 2.24.

Comment 2

[Max Kanat-Alexander]

*** Bug 273309 has been marked as a duplicate of this bug. ***

Comment 3

[Max Kanat-Alexander]

Okay, I'm going to shift the focus of this bug slightly. I'm going to instead move just have_vers and vers_cmp and all those other functions used for requirements-checking into a module.

Comment 4

[Max Kanat-Alexander]

Attachment: v1

Okay, here it is. Pretty simple, overall. I made a few changes as I moved things:

* $modules became a constant called REQUIRED_MODULES
* %ppm_modules became WIN32_MODULE_NAMES, and I also removed all of the 
  "redundant" entries from the hash. Instead, I modified the "install_command" 
  subroutine to print out the proper names of ActiveState modules.
* I updated vers_cmp to the latest version of Sort::Versions.

I tested the patch and it works just fine.

Comment 5

[Vlad Dascalu]

Comment on attachment 226303 [details] [diff] [review]
v1

Runtests.pl no longer passes because Bugzilla::Install::Requirements is not found.

Comment 6

[Max Kanat-Alexander]

Attachment: v2

The first patch was missing the actual Bugzilla::Install::Requirements. :-) So here's the right patch.

Comment 7

[Max Kanat-Alexander]

Attachment: v2.1

The previous patch had tabs in it. Otherwise this one is identical.

Comment 8

[Vlad Dascalu]

Comment on attachment 226305 [details] [diff] [review]
v2

This attachment contains TABs in it.

Comment 9

[Colin Ogilvie [:cso]]

Is there some way that the optional modules can be moved into this module too, or another one?

Comment 10

[Max Kanat-Alexander]

(In reply to comment #9)
> Is there some way that the optional modules can be moved into this module too,
> or another one?

  Yeah, but it would require more re-architecture than I want to do in this bug.

Comment 11

[Colin Ogilvie [:cso]]

Comment on attachment 226306 [details] [diff] [review]
v2.1

This seems to work for me, tested it and simulated the Win32 changes.

Comment 12

[Teemu Mannermaa (:wicked)]

Comment on attachment 226306 [details] [diff] [review]
v2.1

Seems fine on Linux too. Not sure about using global $silent variable, might be better to pass it to the sub. Can be done on other bug. :)

Comment 13

[Max Kanat-Alexander]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.505; previous revision: 1.504
done
RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v
done
Checking in Bugzilla/Install/Requirements.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Requirements.pm,v  <--  Requirements.pm
initial revision: 1.1
done