281519 - Support Windows XP x64(AMD64) build

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Makoto Kato [:m_kato]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Curernt firefox.exe.manifest file only supports X86 processor.  I need support
other X86 platform such as x86-64.

Reproducible: Always

Comment 1

[Makoto Kato [:m_kato]]

Attachment: a patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

[e-mail] is probably a better choice for r/sr, blake is currently
busy with other projects and hasn't been reviewing lately.

Comment 3

[Makoto Kato [:m_kato]]

Gavin, thanks.

I re-send code-review to bryner.

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 173744 [details] [diff] [review]
a patch

According to the docs, processorArchitecture is optional, should we just remove
it?

Comment 5

[Makoto Kato [:m_kato]]

(In reply to comment #4)
> (From update of attachment 173744 [details] [diff] [review] [edit])
> According to the docs, processorArchitecture is optional, should we just remove
> it?

No, we cannot remove it.  If we remove it, OS doesn't detect
processorArchitecture as x64.  (If we remove it, OS seems to detect as x86).  So
we should set it as "*".

Comment 6

[Makoto Kato [:m_kato]]

checked in

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/app/firefox.exe.manifest; new revision: 1.2.38.1;