Support Windows XP x64(AMD64) build

RESOLVED FIXED in Firefox 2 alpha1

Status

()

defect
RESOLVED FIXED
15 years ago
13 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

({fixed1.8.1})

unspecified
Firefox 2 alpha1
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Curernt firefox.exe.manifest file only supports X86 processor.  I need support
other X86 platform such as x86-64.

Reproducible: Always
(Assignee)

Comment 1

15 years ago
Posted patch a patchSplinter Review
(Assignee)

Updated

15 years ago
Attachment #173744 - Flags: superreview?(firefox)
Attachment #173744 - Flags: review?(firefox)
bryner@brianryner.com is probably a better choice for r/sr, blake is currently
busy with other projects and hasn't been reviewing lately.
(Assignee)

Updated

14 years ago
Attachment #173744 - Flags: superreview?(firefox)
Attachment #173744 - Flags: superreview?(bryner)
Attachment #173744 - Flags: review?(firefox)
Attachment #173744 - Flags: review?(bryner)
(Assignee)

Comment 3

14 years ago
Gavin, thanks.

I re-send code-review to bryner.
(Assignee)

Updated

14 years ago
Blocks: 237202
Comment on attachment 173744 [details] [diff] [review]
a patch

According to the docs, processorArchitecture is optional, should we just remove
it?
(Assignee)

Comment 5

14 years ago
(In reply to comment #4)
> (From update of attachment 173744 [details] [diff] [review] [edit])
> According to the docs, processorArchitecture is optional, should we just remove
> it?

No, we cannot remove it.  If we remove it, OS doesn't detect
processorArchitecture as x64.  (If we remove it, OS seems to detect as x86).  So
we should set it as "*".
Attachment #173744 - Flags: superreview?(bryner)
Attachment #173744 - Flags: superreview+
Attachment #173744 - Flags: review?(bryner)
Attachment #173744 - Flags: review+
(Assignee)

Updated

14 years ago
Assignee: firefox → m_kato
(Assignee)

Comment 6

14 years ago
checked in
(Assignee)

Updated

14 years ago
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Attachment #173744 - Flags: approval-branch-1.8.1?(bryner)
Attachment #173744 - Flags: approval-branch-1.8.1?(bryner) → approval-branch-1.8.1+
mozilla/browser/app/firefox.exe.manifest; new revision: 1.2.38.1;
Keywords: fixed1.8.1
Target Milestone: --- → Firefox 2 alpha1
You need to log in before you can comment on or make changes to this bug.