281533 - Typeahead find should have (optional) sound for wraparound

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, enhancement, P5)

Description

[Joshua Goldberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Using typeahead find, I find it hard to tell when I wrap around.  I'd like to be
able to have firefox beep when it does so.  (I think this and any audio cue
should be optional.)

I'm aware of the visual cue in the find toolbar at the bottom, but it's hard to
notice when I'm staring at the highlighted results looking for something, and it
goes by quickly if I'm rapidly hitting C-g.  

(Incidentally, I don't get that indicator on this enter_bug.cgi page.  I'll
submit another bug.)






Reproducible: Always

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[Peter van der Woude [:Peter6]]

So you want a sound for both cases, if it is found and if it is not found (which
is allready implemented)

this may be usefull for visually disabled persons

->CC aaronlev
any thoughts ?

Comment 3

[Aaron Leventhal]

(In reply to comment #2)
> So you want a sound for both cases, if it is found and if it is not found (which
> is allready implemented)
> 
> this may be usefull for visually disabled persons
> 
> ->CC aaronlev
> any thoughts ?

Yes, and for me as well :)

Comment 4

[moz]

Using typeahead find  it is very difficult for me and for more people to know when I wrap around. 

The submitter said that the noticeable alert (not just something little at the end of the page when you are really looking at the middle of the page) should be seen when you wrap around.

Comment 5

[bootleq]

I'm willing to take this bug, proposed changes:

Add a pref accessibility.typeaheadfind.wrappedSoundURL,
accepts values like accessibility.typeaheadfind.soundURL (beep, default or URI of WAV file) and default to empty string.

When the pref value is present and accessibility.typeaheadfind.enablesound is true, play the sound when findbar wrapped.

Comment 6

[bootleq]

Attachment: Bug 281533 - Add findbar WRAPPED sound, r=NeilDeakin,#pdfjs-reviewers

Extend FinderSound module, change playNotFoundSound function to
playSound, takes 1 argument to specify play "not-found" (this replaces
existing usages) or newly added "wrapped" sound.

Add new pref accessibility.typeaheadfind.wrappedSoundURL for user to
set prefer sound file, follows similar convention like existing
typeaheadfind.soundURL.

Comment 7

[bootleq]

This bug is quite old but remains relevant. Its blocking bug has 25 votes and 8 duplicates.
Could we reconsider its priority? Even stays as P5, accepting this patch could help progress related bugs a bit.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d3ae41d18b7
Add findbar WRAPPED sound, r=NeilDeakin

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/7d3ae41d18b7

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Did we want to nominate this for the Fx135 relnotes? Please nominate if yes.