"use Bugzilla::RelationSet" in globals.pl and process_bug.cgi is dead code

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
Bugzilla-General
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

2.19.2
Bugzilla 2.20
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
globals.pl calls "use" on Bugzilla::RelationSet, but it doesn't actually use it.
(Assignee)

Comment 1

13 years ago
Created attachment 173819 [details] [diff] [review]
One-line patch: Remove the "use"

Pretty simple. One line. :-)
Attachment #173819 - Flags: review?
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.20
(Assignee)

Updated

13 years ago
Summary: "use Bugzilla::RelationSet" in globals.pl is dead code → "use Bugzilla::RelationSet" in globals.pl and process_bug.cgi is dead code
(Assignee)

Comment 2

13 years ago
Created attachment 173826 [details] [diff] [review]
Two-line patch, remove it from both files

Turns out that the use statement is also dead in process_bug. That file no
longer uses any RelationSet code.
Attachment #173819 - Attachment is obsolete: true
Attachment #173826 - Flags: review?
(Assignee)

Updated

13 years ago
Attachment #173819 - Flags: review?

Updated

13 years ago
Attachment #173819 - Flags: review+

Updated

13 years ago
Attachment #173826 - Flags: review? → review+
(Assignee)

Updated

13 years ago
Attachment #173819 - Flags: review+
(Assignee)

Updated

13 years ago
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 3

13 years ago
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.301; previous revision: 1.300
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.234; previous revision: 1.233
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.