Closed Bug 281596 Opened 20 years ago Closed 19 years ago

Remove RelationSet from Bugzilla::Bug

Categories

(Bugzilla :: Bugzilla-General, enhancement)

2.19.2
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file, 2 obsolete files)

Bugzilla::Bug uses RelationSet once, and only for a silly purpose. It's easy to
remove RelationSet from Bugzilla::Bug.
It's really easy to remove RelationSet from Bugzilla::Bug.

This is really much faster, too. :-)
Attachment #173824 - Flags: review?
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.20
Blocks: 282145
Comment on attachment 173824 [details] [diff] [review]
Simple Patch: Convert RelationSet to a DBI call

The CC list should be sorted.
Attachment #173824 - Flags: review? → review-
Attached patch v2 (obsolete) — Splinter Review
OK. Fixed the ORDER BY. :-)
Attachment #173824 - Attachment is obsolete: true
Attachment #174430 - Flags: review?(LpSolit)
Comment on attachment 174430 [details] [diff] [review]
v2

>+  if ($cc_ref) {
>+    $self->{'cc'} = $cc_ref;
>   }

Does not work if the CC list is empty. Replace "if ($cc_ref)" by "if
(scalar(@$cc_ref)>0)".
Attachment #174430 - Flags: review?(LpSolit) → review-
Attached patch v3Splinter Review
OK! Fixed that bit. :-)
Attachment #174430 - Attachment is obsolete: true
Attachment #174476 - Flags: review?(LpSolit)
Comment on attachment 174476 [details] [diff] [review]
v3

Now it's good! r=LpSolit
Attachment #174476 - Flags: review?(LpSolit) → review+
Flags: approval?
Flags: approval? → approval+
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.56; previous revision: 1.55
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: