Closed
Bug 281596
Opened 20 years ago
Closed 19 years ago
Remove RelationSet from Bugzilla::Bug
Categories
(Bugzilla :: Bugzilla-General, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file, 2 obsolete files)
1.16 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Bugzilla::Bug uses RelationSet once, and only for a silly purpose. It's easy to remove RelationSet from Bugzilla::Bug.
Assignee | ||
Comment 1•20 years ago
|
||
It's really easy to remove RelationSet from Bugzilla::Bug. This is really much faster, too. :-)
Attachment #173824 -
Flags: review?
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.20
Comment 2•19 years ago
|
||
Comment on attachment 173824 [details] [diff] [review] Simple Patch: Convert RelationSet to a DBI call The CC list should be sorted.
Attachment #173824 -
Flags: review? → review-
Assignee | ||
Comment 3•19 years ago
|
||
OK. Fixed the ORDER BY. :-)
Attachment #173824 -
Attachment is obsolete: true
Attachment #174430 -
Flags: review?(LpSolit)
Comment 4•19 years ago
|
||
Comment on attachment 174430 [details] [diff] [review] v2 >+ if ($cc_ref) { >+ $self->{'cc'} = $cc_ref; > } Does not work if the CC list is empty. Replace "if ($cc_ref)" by "if (scalar(@$cc_ref)>0)".
Attachment #174430 -
Flags: review?(LpSolit) → review-
Assignee | ||
Comment 5•19 years ago
|
||
OK! Fixed that bit. :-)
Attachment #174430 -
Attachment is obsolete: true
Attachment #174476 -
Flags: review?(LpSolit)
Comment 6•19 years ago
|
||
Comment on attachment 174476 [details] [diff] [review] v3 Now it's good! r=LpSolit
Attachment #174476 -
Flags: review?(LpSolit) → review+
Updated•19 years ago
|
Flags: approval?
Updated•19 years ago
|
Flags: approval? → approval+
Assignee | ||
Comment 7•19 years ago
|
||
Checking in Bugzilla/Bug.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm new revision: 1.56; previous revision: 1.55 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•