281606 - instanceof does not throw exception for objects not implementing [[HasInstance]] method

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P4)

Description

[Milind]

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 5.0; H010818)
Build Identifier: 

According to specs -- section 11.8.6 of ECMA-262 -- instanceof operator
on objects NOT implementing [[HasInstance]] internal method should 
throw a TypeError exception. Hence, in the following script the
catch block must get executed, (since Math object does not implement
[[HasInstance]] method).

var varBool1;
var objNumber = new Number(5);
			
try{
    /* Math object can not be used for instantiation */
    /* Hence, TypeError */
    varBool1 = objNumber instanceof Math; 
			
}
catch(e){
    print("Exception " + e.name + "occurred");			
}



Reproducible: Always

Steps to Reproduce:
1. Copy the following script in a file, say t.js

var varBool1;
var objNumber = new Number(5);
			
try{
    /* Math object can not be used for instantiation */
    /* Hence, TypeError */
    varBool1 = objNumber instanceof Math; 
			
}
catch(e){
    print("Exception " + e.name + "occurred");			
}


2. Launch Spidermonkey shell with above script-file as input. eg. js t.js

3. Watch the output on the screen

Actual Results:  
Nothing was printed on screen


Expected Results:  
Should have printed following:

Exception TypeError occurred

Comment 1

[Brendan Eich [:brendan]]

Reporter: no need for "STD Non-Compliance: " at the start of the summary.

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 173932 [details] [diff] [review]
fix

r=shaver

Comment 4

[Brendan Eich [:brendan]]

Fixed.

Bob, do you want to take over QA Contact for "JavaScript Engine" from
[e-mail]?

/be

Comment 5

[Bob Clary [:bc] (inactive)]

If that is ok with Phil, I would be happy to be qa.

Comment 6

[Bob Clary [:bc] (inactive)]

the second testcase in ecma_2/instanceof/instanceof-003.js is invalid.
o = {}; o instanceof o

Comment 7

[Bob Clary [:bc] (inactive)]

the second testcase in js/tests/ecma_2/instanceof/regress-7635.js is a repeat of
the o = {}; o instanceof o which is invalid after this bug fix. checked in.

js/tests/js1_5/Regress/regress-281606.js checked in with Milind
<[e-mail]> as primary contributor.

Comment 8

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/ecma_2/instanceof/instanceof-003.js,v  <-- 
instanceof-003.js
new revision: 1.2; previous revision: 1.1

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.0.2,1.8,1.9a1 20060401 win/mac/linux