281647 - syntax eror in searchbar.css

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Hiro]

The semicolon has been forgotten in the line of URL.

Comment 1

[Asaf Romano (gone)]

where exactly? looks fine to me

Comment 2

[José Jeria]

 18   height: 16px;
 19   margin: 0px
 20   padding: 0px;

Line 19: No semicolon in the end

Comment 3

[Anne (:annevk)]

Attachment: patch #1

Who needs to review this?

Also, shouldn't we use '0' instead of '0px'?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 174672 [details] [diff] [review]
patch #1

This needs review from the owner of this code; maybe they don't actually want
the 0 margin and padding, since they clearly had no issues with those
declarations not being applied....

Comment 5

[Asaf Romano (gone)]

Anne, the owner of this code is Kevin Gerich (webmail at kmgerich dot com)

Comment 6

[Anne (:annevk)]

Comment on attachment 174672 [details] [diff] [review]
patch #1

Thanks.

Comment 7

[Kevin Gerich]

Comment on attachment 174672 [details] [diff] [review]
patch #1

I just removed the rule. Thanks for pointing it out Anne

Comment 8

[Anne (:annevk)]

You know the 'padding' declaration was dropped as well? (Before you removed only
'margin'.)

Comment 9

[Kevin Gerich]

Right. I removed the padding as well.

Comment 10

[Anne (:annevk)]

-> VERIFIED.