Closed Bug 281652 Opened 15 years ago Closed 15 years ago

syntax eror in pageinfo.css(text-style: italic;)

Categories

(Firefox :: General, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: sugar.waffle, Assigned: annevk)

References

()

Details

Attachments

(2 files)

See URL.
The mistake as which the Windows version was the same was found. 
http://lxr.mozilla.org/mozilla/source/browser/themes/winstripe/browser/pageInfo.css#72
OS: MacOS X → All
Hardware: Macintosh → All
Summary: syntax eror in pageinfo.css → syntax eror in pageinfo.css(text-style: italic;)
Attached patch patch #1Splinter Review
zbarsky, can you review this? Or do I need to ask someone else?
Assignee: firefox → bug
Status: NEW → ASSIGNED
Attachment #174673 - Flags: superreview?(bzbarsky)
Attachment #174673 - Flags: review?(bzbarsky)
Attachment #174673 - Flags: superreview?(bzbarsky)
Attachment #174673 - Flags: superreview+
Attachment #174673 - Flags: review?(bzbarsky)
Attachment #174673 - Flags: review+
Checked in to trunk for 1.8b2.
There was a typo in the fix as well:

+	font-syle: italic;

instead of:

+	font-style: italic;
Attached patch patch #2Splinter Review
Ugh, sorry about that.
Attachment #174785 - Flags: superreview?(bzbarsky)
Attachment #174785 - Flags: review?(bzbarsky)
Comment on attachment 174785 [details] [diff] [review]
patch #2

Please take out the unrelated changes.
Attachment #174785 - Flags: superreview?(bzbarsky)
Attachment #174785 - Flags: superreview-
Attachment #174785 - Flags: review?(bzbarsky)
Attachment #174785 - Flags: review-
I checked in just the typo fix from patch #2
Hmm, I already had a new patch ready when I saw that first comment :-)

Anyway, marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.