281690 - days are shown two times in Minimonth (depending on timezone)

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Mostafa Hosseini]

In windows XP, if the timezone is set to Bucharest (GMT+2) and "Automatically
adjust clock for DST" is selected, calendar shows March 27 as March 26.So there
will be two March 26 boxes in the view. If "Automatically adjust clock for DST"
is unchecked the problem won't show up.

Comment 1

[Joey Minta]

*** Bug 309552 has been marked as a duplicate of this bug. ***

Comment 2

[Joey Minta]

*** Bug 287923 has been marked as a duplicate of this bug. ***

Comment 3

[Joey Minta]

WFM in Sunbird 0.3a1+ on Linux, GMT-5.  Mostafah, can you still reproduce this?

Comment 4

[Stefan Sitter [:ssitter]]

I can confirm this with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051110 Mozilla Sunbird/0.3a1+.

If timezone is set to GMT+2 (Athens,...) I see 26/27/28 in month view.

If timezone is set to GMT+2 (Bucharest) I see 26/26/28 in month view and 26/26/27/28 in mini calendar. Also navigation and display in day view and multiweek view seems totally messed up.

If timezone is set to GMT+2 (Cairo) I see 26/27/28 in month view.

That's weird. I'm not sure if this is a Sunbird or Windows problem.

Comment 5

[Matthew (lilmatt) Willis]

Reassigning all automatically assigned bugs from Mostafa to nobody@m.o

Bugspam filter: TorontoMostafaMove

Comment 6

[Sebastian Schwieger]

*** Bug 356582 has been marked as a duplicate of this bug. ***

Comment 7

[Sebastian Schwieger]

in bug 356582 there occurs a similar problem on October 13th using system timezone setting Santiago (GMT -04:00). A notable difference would be that October 14th is not replaced but shifted one day. This bug reports a replacement, but it is likely the same underlying problem. Note, that bug 343894 reports the same on a linux system ((Debian-1.5) as well. bug 298686 is a candidate for a Windows 2000 system. It has not jet been seen on Mac system, but I am going to mark it as OS=All.

Comment 9

[Simon Paquet [:sipaq]]

Steps to reproduce on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3pre) Gecko/20070315 Calendar/0.5pre

1. Switch to the America/Sao Paulo timezone (GMT-03:00) in Sunbird/Lightning
2. Switch your system timezone to the same timezone.
3. Move the minimonth to November 2007

Actual results:
November 3rd appears two times. November 4th does not appear in the minimonth, but is shown in the view.

Expected results:
Show November 3rd 2007 only once in minimonth.

Comment 11

[Diego Torres]

I confirm this bug on:
-Windows XP
-Time zone: Santiago GMT-4.00 (Pacific SA Standard Time)
-Automatic daylight saving: ON
-Lightning Timezone: America/Santiago

On Minimonth, October 13th appears twice (Sa and Su) without replacing Su 14th. Instead, it shifts the calendar one day on. On month and week view, the dates are correctly shown. However, if you click either Sa 13th or "Su 13th" in the Minimonth, they will both take you to Sa 13th on the month view. For instance, if you click in the Minimonth on the shifted "M 14th" it'll take you to the actual Su 14th on the month view. The link appears to be associated only to numbers, not day of the week. 

Comment 13

[Stefan Sitter [:ssitter]]

This seems to be specific to timezones that start/end daylight saving time at 00:00. The minimonth also uses a date with time 00:00 to do all the calculations for display purpose.

If I change showMonth() in minimonth.xml to initialize the date given with a different time (e.g. 12:34) the issue seems to be fixed: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/resources/content/datetimepickers/minimonth.xml&rev=1.18&mark=379#369

But I'm not sure if this affects other functionality of the minimonth that depends on the date and time. Philipp, Michael, you have more experience with minimonth than me. Do you see a possible regression that could be caused by this?

Comment 17

[Ricardo Szczerbacki]

(I copied pasted the message changing, using my data)
The same occured to me with:
-Windows XP
-Time zone: America/Sao Paulo timezone (GMT-03:00)
-Automatic daylight saving: ON

On Minimonth, October 11th appears twice (Sa and Su) without replacing Su 12th.
Instead, it shifts the calendar one day on. On month and week view, the dates
are correctly shown. 

Comment 18

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to comment #13)
> This seems to be specific to timezones that start/end daylight saving time at
> 00:00. The minimonth also uses a date with time 00:00 to do all the
> calculations for display purpose.
> 
> If I change showMonth() in minimonth.xml to initialize the date given with a
> different time (e.g. 12:34) the issue seems to be fixed:
> http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/resources/content/datetimepickers/minimonth.xml&rev=1.18&mark=379#369
> 
> But I'm not sure if this affects other functionality of the minimonth that
> depends on the date and time. Philipp, Michael, you have more experience with
> minimonth than me. Do you see a possible regression that could be caused by
> this?
>

I haven't noticed anything that could be regressed by this change, I think setting the hour to 12 and adding a comment is fine and worth a try. Utimately, we should decide if we want to abandon trying to get our minimonth into toolkit and use calIDateTime. Incrementing the day on a calIDateTime doesn't have this problem afaik.

Patches welcome!

Comment 22

[Marco Varanda]

I confirm this BUG.

I´m using Lightning 0.9, America/Sao Paulo Time Zone, with Thunderbird 2.0.0.17, and there are twice October 11, 2008.

We have 123 users, and there are about 80 users using TB, it was dificult to change Outlook to TB (IMAP) because the users are familiar, and if we found simple bugs like this, the complains growth.

I´m satisfied with TB, Lightning, Firefox, etc, and I´d thank you, but please, can someone fix this bug ?

varanda

Comment 23

[Marco Varanda]

If I disable daylight saving in Windows, this problem disappear.

You must close and start again TB/Calendar

:-)

Comment 25

[Marco Varanda]

Please, friends

Lets Vote on item "importance" at beginning

thanx

Comment 26

[Martin Schröder [:mschroeder]]

Marco, only release drivers are allowed to grant flags!

Comment 28

[faramir0cl]

I have the same problem, with both lightning 0,8 and 0,9. I'm using Windows XP Pro SP3, spanish version, with Thunderbird 2.0.0.17 es-ar, and local timezone America/Santiago (daylight saving ON). The problem is saturday october 11 is duplicated in sunday october 12 place too (in calendar view). So I see monday 12 (which is wrong, it should be monday 13), and so on. Fortunatelly November is showed right.

Comment 29

[Marco Varanda]

If you disable daylight saving in Windows, this problem disappear.

You must close and start again TB/Calendar

Comment 30

[faramir0cl]

True, that solves the problem, but forces me to change my location to another timezone, and I don't know if that would cause other problems...

Comment 31

[Marco Varanda]

Yes I know

The best choice is someone could fix this bug.

Comment 32

[Bryan Clark (DevTools PM) [:clarkbw]]

This bug is definitely a problem, but I don't think we should block releasing Thunderbird and Calendar together if this isn't fixed.  marking tb-int-

Comment 34

[Carlos Le Mare]

In my Calendar (WinXP SP2, Thunderbird 2.0.0.17, Lightning 0.9
build 2008091719, Google Calendar 0.5.1) Appears that the day is
not correctly showing according to the date.

Today is Monday 20, October 2008, and the minimonth shows that today is Tuesday 20, October 2008.

GMT-4 Santiago Chile, daylight saving is ON. Putting it in Off produce problems with alerts showing at different hour than the specified (wich is worst).

clemare.

Comment 35

[Sidnei Gomes]

Same here.
Windows XP SP2
GMT-3 - Americas - Sao Paulo
But instead of the 11th day, the 18th day is duplicated.
It is annoying and change the timezone or daylight saving period is not an option.

Comment 36

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Here we go, its been a bit too long to wait for [good first bug] ;-) I see no further implications when setting a time. Also fixes some parseInt() calls so lets give it a go.

Comment 39

[Martin Schröder [:mschroeder]]

Comment on attachment 344972 [details] [diff] [review]
Fix - v1

r=mschroeder, but

>-           year.setFullYear(Math.max(1, compFullYear - parseInt(years.length / 2, 10) + 1));
>+           year.setFullYear(Math.max(1, compFullYear - parseInt(years.length / 2, 10) + 1), 10);

>-           years[0].disabled = (parseInt(years[1].getAttribute("value"), 10) + offset < 2);
>+           years[0].disabled = (parseInt(years[1].getAttribute("value"), 10) + offset < 2, 10);

shouldn't be changed.

Comment 40

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/1fd8c2b56030>

-> FIXED

Comment 41

[Daniel Boelzle [:dbo]]

I still don't understand this fix and it looks hacky to me. Could anybody please explain it to me?

Comment 42

[Willie Ram]

When do you estimate this will be incorporated into a new release? Any possibility of applying it without rebuilding? We have XP SP3, Spanish, Argentina, Timezone GMT-3.00 Buenos Aires , DST ON.

Comment 43

[Kunzang Tobgye]

Attachment: Bhutan Holidays

Comment 44

[Simon Paquet [:sipaq]]

Kunzang Tobgye,
what is the purpose of your attachment here in this bug?

Comment 47

[Leandro]

I do have the same problem on Ubuntu 9.04 (64 bits), running Thunderbird 2.0.0.21.
Lightning version 0.9.

The only difference here is that the duplicate day is October 17th 2009.

My screenshot will be upload for you guys here.

Comment 48

[Leandro]

Attachment: Same issue on ubuntu - October 17th 2009

Comment 49

[Stefan Sitter [:ssitter]]

(In reply to comment #47)

This issue ought to be fixed in current Lightning 1.0pre test builds. But this fix is still waiting for verification by someone affected by this issue in the 0.9 builds.

Comment 50

[Ulisses]

Same issue in 0.9 version build 2008092321 on:
 - Mandriva Linux 2009.1 Spring x64 - US English
 - Windows 7 x64 - Brazilian Portuguese
 - Windows XP Professional - Brazilian Portuguese

Timezone set to America/Sao Paulo

Comment 54

[faramir0cl]

Same issue on Lightning 0.9 (build 2008091719), on TB 2.0.0.23, Spanish (AR)
On Windows XP Professional, SP3, timezone América/Santiago (GMT-4), the duplicated day is October 10.

Comment 55

[faramir0cl]

(In reply to comment #49)
> (In reply to comment #47)
> 
> This issue ought to be fixed in current Lightning 1.0pre test builds. But this
> fix is still waiting for verification by someone affected by this issue in the
> 0.9 builds.

Maybe if somebody builds a patched 0.9 version, we could test it... I don't have any idea about building addons.

Comment 57

[razer.anthom]

Curiously, I saw same error in Win Vista, in that component, side bar I think, that shows a calendar. Same day duplicated...

Comment 60

[Joe]

Ubuntu Jaunty
Thunderbird 2.0.0.23
Lightning 0.9
U.S. Central Time Zone

I have the same issue or a closely similar one, using Lightning. My small monthly calendar for November 2009 shows two November Firsts, one on Sunday (correct) and another on Monday (incorrect). All following dates visible on this calendar are therefore displaced a day late. If I scroll forward into December, the dates are where they belong. However, if I scroll back into October, the first days of November visible at the bottom still show the error.

ALSO - The first few times I started Lightning, all of the minimonth weekday labels were "Sa." Then for a couple of times, they were "Sa Sa Su Su Mo Tu We." Then they briefly went back to all "Sa" again, and now they appear to be normal. I have no idea whether this bug is related to the first bug or not.

From what I read here, the duplicate days thing is being addressed in 1.0. I'll post this anyway just in case it might add anything useful. I have "fixed" these issues for the time being by using Evolution instead :)

Comment 61

[Joe]

I have downloaded Tbird 3 Beta 4 and Lightning 1.0 to try them together, and from what I can see, my issue has been fixed, or at least I haven't run into it with the scrolling back and forth that I've done so far. Good! Looking forward to both of these coming out of Beta.