281733 - testfile mail transport cannot write to testfile

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect, P2)

Description

[Joel Peshkin]

If the "testfile" method is selected for email delivery, it attempts to write to
the Bugzilla program directory which is not normally writable by the webserver
user.  This needs to be in the data/ directory.

Comment 1

[Joel Peshkin]

fefe

Comment 2

[Joel Peshkin]

Attachment: use $datadir/mailer.testfile

Comment 3

[Frédéric Buclin]

Comment on attachment 174120 [details] [diff] [review]
use $datadir/mailer.testfile

Does not fix the problem.

Adding a print command in testfile.pm shows that this line has no effect.

Comment 4

[Frédéric Buclin]

Colin found the right solution:
    my $mailer = new Mail::Mailer Param("maildeliverymethod"), @args;
    if (Param("maildeliverymethod") eq "testfile") {
        $Mail::Mailer::testfile::config{outfile} = "$datadir/mailer.testfile";
    }

This works with version 1.62.

Comment 5

[Frédéric Buclin]

Attachment: use $datadir/mailer.testfile, v2

I implemented what I suggested in my previous comment.

Comment 6

[Joel Peshkin]

One note....

On checkin, please add a comment ...
# Outfile is set to correct location AFTER $mailer is created for compatibility 
# with Mail::Mailer version 1.62.

Comment 7

[Colin Ogilvie [:cso]]

(In reply to comment #6)
> On checkin, please add a comment ...
> # Outfile is set to correct location AFTER $mailer is created for compatibility 
> # with Mail::Mailer version 1.62.

That comment is technically inaccurate - from tests, even with Mail::Mailer 1.66
(at least on Windows) the line needs to be after $mailer creation.

Comment 8

[Max Kanat-Alexander]

Joel: There seems to be quite a bit of contention over whether the comment is
needed. Colin and LpSolit say that the way it's done is necessary even in 1.66.
So I'm not going to add the comment on checkin. If we later determine that it's
necessary, then we can maybe check it in without a patch, if we ask justdave in IRC.

Comment 9

[Max Kanat-Alexander]

Checking in Bugzilla/BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.32; previous revision: 1.31
done

Comment 10

[Joel Peshkin]

WRT comment 8
OK By me