281834 - --enable-cpp-rtti builds broken on FC3

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

xpcom/reflect has wrong defines for XPTC_EXPORT on linux when used with FC3's
gcc. this means that typeinfo for nsXPTCStubBase is not exported, which causes
unresolved symbols at runtime.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 173978 [details] [diff] [review]
patch

Oops, I thought this was committed some time ago.

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 173978 [details] [diff] [review]
patch

This change ends up causing XPConnect crashes on win32 because the NS_EXPORT
macro sets declspec(stdcall) on Windows (incorrectly, IMO, but changing it
requires more investigation).  This is a problem because the assembly
implementation of XPTC_InvokeByIndex does not pop the arguments which a
|stdcall| function must do.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 173978 [details] [diff] [review]
patch

hm, really? http://lxr.mozilla.org/seamonkey/source/xpcom/base/nscore.h#163
does not look like it does; it does only for the NS_EXPORT_(t) variant which I
don't use... (and which I avoided because it sets stdcall)

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 173978 [details] [diff] [review]
patch

Ah, you're right, I was testing a slightly different patch.

Comment 6

[Darin Fisher]

Comment on attachment 173978 [details] [diff] [review]
patch

rs=darin

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 173978 [details] [diff] [review]
patch

this should be a low risk patch... it only marks some more stuff as exported

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 173978 [details] [diff] [review]
patch

a=asa for checkin to 1.8b

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in xpcom/reflect/xptcall/public/xptcall.h;
/cvsroot/mozilla/xpcom/reflect/xptcall/public/xptcall.h,v  <--  xptcall.h
new revision: 1.26; previous revision: 1.25
done