281846 - added feed not initially displayed in RSS Subscriptions dialog

Status: RESOLVED WORKSFORME

(MailNews Core :: Feed Reader, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2005021006-trunk tbird bits. when I first add an RSS feed, it
doesn't initially appear in the RSS Subscriptions dialog.

I didn't see and JS console messages, though.

1. for the RSS account, click "manage subscriptions" from Account Central.

2. click Add Feed button.

3. enter an rss link, eg, http://www.mozilla.org/news.rdf into the Feed URL
textfield and click OK.

results: that feed isn't displayed (invisible) in the RSS Subscriptions dialog.
it does dynamically appear in the folder pane of the mail window.

workarounds:

- it does appear after I close then reopen the dialog
- also, if I hit the down arrow key enough in the dialog, it'll eventually appear.

Comment 1

[Scott MacGregor]

This seems to work ok for me on Windows. 

Question where in the list is the new feed folder getting added? at the top, at
the bottom, some where in the middle? May just be a tree painting bug if moving
the arrow key through the tree selection causes it to suddenly become visible. 

What happens if you drag a feed to the subscription window, same issue? How
about with dragging a feed from one folder to another?

Comment 2

[sairuh (rarely reading bugmail)]

also see this on mac (10.3.8), 2005021004-trunk.

I cannot seem to get d'n'd of rss links to work at all (from browser window to
subscription dlg).

Comment 3

[Scott MacGregor]

you have to drop it into a folder container....(FYI)

where in the list is the new feed showing up? at the top, bottom or middle?

Comment 4

[Scott MacGregor]

Attachment: fix for the mac

I haven't seen sarah's bug on the mac yet. But I did notice that the twisties
for folders in the subscription dialog were not always getting re-drawn to
represent the open /closed state of the folder.

This patch fixes that problem for Mac OS X.

Comment 5

[sairuh (rarely reading bugmail)]

(In reply to comment #3)
> you have to drop it into a folder container....(FYI)

aha! thanks, that does work.

> where in the list is the new feed showing up? at the top, bottom or middle?

if it's the first feed added, it's always at the top. subsequent feeds appear to
be added in alphabetic order, so their position will vary depending on their title.

yeah, I think I see what you mean in comment 4. did you also see the extra rss
icons being drawn for each added feed? I'll attach a screenshot.

Comment 6

[sairuh (rarely reading bugmail)]

Attachment: illustrates the twisty issue in comment 4, plus the extra feed icons appended to the list

Comment 7

[Scott MacGregor]

I fixed the extra empty feed line being added with the patch listed above. It
should have been in the 2/11 builds. 

Comment 8

[Scott MacGregor]

How is this looking with today's build Sarah?

Comment 9

[sairuh (rarely reading bugmail)]

discussed with Scott: will show him what I see next time we're both in the office.

Comment 10

[Magnus Melin [:mkmelin]]

WFM on latest-trunk.

Comment 11

[Magnus Melin [:mkmelin]]

->WFM since a long time ago