281862 - AutoComplete MDBResult's GetCommentAt method returns NS_ERROR_NOT_IMPLEMENTED but it is!

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Witness the insanity:

http://lxr.mozilla.org/seamonkey/source/toolkit/components/autocomplete/src/nsAutoCompleteMdbResult.cpp#128

nsAutoCompleteMdbResult::GetCommentAt is properly implemented except some bozo
*kicks hewitt* forgot to change return NS_ERROR_NOT_IMPLEMENTED to return NS_OK! 

This doesn't affect any Firefox code since all the uses are in C++ and they all
ignore the error code... in JS however not only does it throw, it also doesn't
return the out param, meaning that I can't even paper over it with try..catch
because it'd still not give me any useful data. This shipped with 1.0 to 25
million people. Curses. C++ shim, here I come.... but let's fix it anyway.

Comment 1

[Simon Bünzli]

Attachment: return NS_OK

Any reason this obvious one-line fix should not get in for Firefox 1.5?

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 198768 [details] [diff] [review]
return NS_OK

driveby r=me, probably useful for Fx2 at some point.

Comment 3

[Benjamin Smedberg]

Comment on attachment 198768 [details] [diff] [review]
return NS_OK

This code is disappearing on the 1.8 branch.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 198768 [details] [diff] [review]
return NS_OK

Or not... ;)

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/autocomplete/src/nsAutoCompleteMdbResult.cpp 	1.9.10.2
mozilla/toolkit/components/autocomplete/src/nsAutoCompleteMdbResult.cpp 	1.13