281886 - Command-line service broken

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Dmbtech]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050210 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050210 Firefox/1.0+

Command-line service for chatzilla is broke. firefox/mozilla -chat or /chat no
longer works do to recent changes in the trunk.

Reproducible: Always

Steps to Reproduce:
1. Get a recent trunk build of fx or sm
2. Try to start it Linux: ./firefox -chat windows: firefox /chat || ./mozilla
-chat windows: mozilla /chat


Actual Results:  
Warning: unrecognized command line flag -chat

Expected Results:  
Starts chatzilla

Comment 1

[James Ross]

What actually happens, JOOI? Does a blank browser window open?

Comment 2

[Dmbtech]

It gives that in the console, then it just opens up firefox normally, as it
would for any invalid command. (firefox --blah)

Comment 3

[Justin Turner Arthur]

Because the described behavior is no longer reproducable on SeaMonkey, I have a
feeling that it is a regression of bug 276588. This might mean we need to do
some work on chatzilla-service.js or maybe even consider creating a new
component file specifically for applications that utilize the new toolkit.
http://wiki.mozilla.org/index.php/XUL:Command_Line_Handling describes the
toolkit's new command line handling.

Comment 4

[James Ross]

(In reply to comment #3)
> Because the described behavior is no longer reproducable on SeaMonkey

This was never an issue in SeaMonkey.

Comment 5

[James Ross]

(In reply to comment #3)
> toolkit's new command line handling.

This bug was created by dmb on my behalf for exactly this. It is just a reminder
that it needs doing (or FF support killing).

Comment 6

[Justin Turner Arthur]

> This was never an issue in SeaMonkey.

I assumed it was given that step 2 of the steps to reproduce appeared to
describe invoking chatzilla by both the "firefox" and "mozilla" executables.

Comment 7

[Dmbtech]

(In reply to comment #6)
> > This was never an issue in SeaMonkey.
> 
> I assumed it was given that step 2 of the steps to reproduce appeared to
> describe invoking chatzilla by both the "firefox" and "mozilla" executables.
Oh sry, thats actually a mistake Its supposed to be only firefox, i must of been
real tired when i was creating the bug, sry all.

Comment 8

[Rob Marshall [tH]]

Attachment: patch based on DOM Inspector changes

I've copied the changes from attachment 170255 [details] [diff] [review], commented out the parameters
bit, and set cmdLine.preventDefault so the browser window doesn't open.

This works for Firefox/1.0+ 20070715, and I've created an XPI for testing.
http://worms.rdmsoft.com/temp/cZ/chatzilla-0.9.67+-rdmsoft-clh1.xpi

Comment 9

[Rob Marshall [tH]]

Attachment: updated patch + parameter support

Comment 10

[James Ross]

Comment on attachment 204236 [details] [diff] [review]
updated patch + parameter support

r=silver

Comment 11

[James Ross]

checked in --> FIXED.