Closed Bug 281907 Opened 20 years ago Closed 19 years ago

replace uses of -moz-opacity with opacity

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: annevk, Assigned: annevk)

Details

(Keywords: css3)

Attachments

(2 files, 1 obsolete file)

patch #2
25.02 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
patch #3 - last 4
2.70 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
See also:
 <http://lxr.mozilla.org/seamonkey/search?string=-moz-opacity>

Patch coming up...
Attached patch patch #1 (obsolete) — — Splinter Review 
If I need sr from someone else please tell me. I'm new to the process.
Attachment #174028 - Flags: superreview?(bzbarsky)
Attachment #174028 - Flags: review?(bzbarsky)
Attachment #174028 - Attachment is obsolete: true
Attachment #174028 - Flags: superreview?(bzbarsky)
Attachment #174028 - Flags: review?(bzbarsky)
Attached patch patch #2 — — Splinter Review 

        Attachment #174070 -
        Flags: superreview?(bzbarsky)

        Attachment #174070 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 174070 [details] [diff] [review]
patch #2

r+sr=bzbarsky

        Attachment #174070 -
        Flags: superreview?(bzbarsky)

        Attachment #174070 -
        Flags: superreview+

        Attachment #174070 -
        Flags: review?(bzbarsky)

        Attachment #174070 -
        Flags: review+

    
    

    
  
Just for the record which the summary did not tell me initially.

This replaces the parts of internal code and CSS where we used -moz-opacity
still which was kept parseable as a legacy measure, (Since so many websites and
extensions made some use of it).

Thanks Anne!
Summary: replace -moz-opacity with opacity → replace uses of -moz-opacity with opacity

    
    

    
  
bz, tree is open I believe. Could you check this in?

    
    

    
  
Checked in to trunk for 1.8b2.

    
    

    
  


  
This replaces the last four '-moz-opacity' properties to 'opacity' in the
trunk.

After that we only have the mapping code so that '-moz-opacity' works
equivalent to 'opacity'. I guess we should remove that too eventually, so that
we push people to use standard properties instead of proprietary ones.

        Attachment #174786 -
        Flags: superreview?(bzbarsky)

        Attachment #174786 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 174786 [details] [diff] [review]
patch #3 - last 4

r+sr=bzbarsky

> I guess we should remove that too eventually

I don't think so, no.

        Attachment #174786 -
        Flags: superreview?(bzbarsky)

        Attachment #174786 -
        Flags: superreview+

        Attachment #174786 -
        Flags: review?(bzbarsky)

        Attachment #174786 -
        Flags: review+

    
    

    
  
Checked that last patch in, after merging it to trunk...

    
    

    
  
(In reply to comment #8)
> I don't think so, no.

Too bad. Anyway, FIXED. Thanks for the reviews and CVS commits.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
    

    
  
Four more have snuck in in a couple theme files since this was fixed:
http://lxr.mozilla.org/seamonkey/search?string=-moz-opacity


          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: