Status

()

Core
Layout
RESOLVED INVALID
14 years ago
13 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
A few build changes to make mozilla/layout compile for wince.
(Assignee)

Comment 1

14 years ago
Created attachment 174048 [details] [diff] [review]
Patch v.1

this patch does the following:

1) I have noticed that sometimes gfx returns no font metrics.  In this case, we
crash since we are checking if GetMetricsFor does really return a fm.

2) On WinCE (at least Pocket PC 2003), CreateEvent is not defined as it is on
other Win32 platforms.
(Assignee)

Updated

14 years ago
Assignee: nobody → dougt
Status: NEW → ASSIGNED
Attachment #174048 - Flags: review?(dbaron)
Comment on attachment 174048 [details] [diff] [review]
Patch v.1

>Index: layout/generic/nsHTMLReflowState.cpp
>     nsCOMPtr<nsIFontMetrics> fm;
>     deviceContext->GetMetricsFor(font->mFont, vis->mLangGroup,
>                                  *getter_AddRefs(fm));
>-    if (unit == eStyleUnit_Factor) {
>+    if (unit == eStyleUnit_Factor && fm) {

GetMetricsFor is required to return non-null.  If it's not doing that, fix the
gfx code so that it does instead.

r=dbaron on the other half, though
Attachment #174048 - Flags: review?(dbaron) → review-
That said, I'm puzzled as to why you need to make the other change.  It seems
like it could break things -- we're using a member function called CreateEvent,
presumably, and we don't want it to pick up a different name under WINCE.  So,
actually, I want more information before saying r=dbaron on the second half.
(Assignee)

Comment 4

14 years ago
yes, it may be that neither of these changes will be required.
(Assignee)

Comment 5

13 years ago
no change was required.  marking invalid.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.