281944 - Port Layout to WinCE

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Doug Turner (:dougt)]

A few build changes to make mozilla/layout compile for wince.

Comment 1

[Doug Turner (:dougt)]

Attachment: Patch v.1

this patch does the following:

1) I have noticed that sometimes gfx returns no font metrics.  In this case, we
crash since we are checking if GetMetricsFor does really return a fm.

2) On WinCE (at least Pocket PC 2003), CreateEvent is not defined as it is on
other Win32 platforms.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 174048 [details] [diff] [review]
Patch v.1

>Index: layout/generic/nsHTMLReflowState.cpp
>     nsCOMPtr<nsIFontMetrics> fm;
>     deviceContext->GetMetricsFor(font->mFont, vis->mLangGroup,
>                                  *getter_AddRefs(fm));
>-    if (unit == eStyleUnit_Factor) {
>+    if (unit == eStyleUnit_Factor && fm) {

GetMetricsFor is required to return non-null.  If it's not doing that, fix the
gfx code so that it does instead.

r=dbaron on the other half, though

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

That said, I'm puzzled as to why you need to make the other change.  It seems
like it could break things -- we're using a member function called CreateEvent,
presumably, and we don't want it to pick up a different name under WINCE.  So,
actually, I want more information before saying r=dbaron on the second half.

Comment 4

[Doug Turner (:dougt)]

yes, it may be that neither of these changes will be required.

Comment 5

[Doug Turner (:dougt)]

no change was required.  marking invalid.