281952 - XULrunner build error: unresolved external symbol __pr_hInstance

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[James Ross]

nsDllMain.obj : error LNK2019: unresolved external symbol __pr_hInstance
referenced in function _DllMain@12
xul.dll : fatal error LNK1120: 1 unresolved externals
make[1]: *** [xul.dll] Error 96

Caused by the patch to bug 280245.

Comment 1

[James Ross]

In:

make[1]: Leaving directory `/cygdrive/m/tree-xulrunner-main/objdir/toolkit/library'
make: *** [all] Error 2
make: Leaving directory `/cygdrive/m/tree-xulrunner-main/objdir/toolkit/library'

Comment 2

[Benjamin Smedberg]

Doug, could you take a look at this? the global hinstance was necessary for
xulrunner.

Comment 3

[Doug Turner (:dougt)]

I guess i don't have enough background as to why you have to set __pr_hInstance?
 Doesn't GetModuleHandle(NULL) do the right thing for us in XPCOM?

Comment 4

[Benjamin Smedberg]

GetModuleHandle(NULL) returns the handle of the *executable*, while the previous
__pr_histance was the handle of the XPCOM DLL. I'm not sure it matters.

I was just copying that code from XPCOM to toolkit. If GetModuleHandle(NULL) is
fine, we can remove the same code from xulrunner that you removed from xpcom.

Comment 5

[Doug Turner (:dougt)]

yeah, i think that will work just fine.  I will come up with a patch.  

Comment 6

[Doug Turner (:dougt)]

Attachment: Patch v.1

Comment 7

[Benjamin Smedberg]

Comment on attachment 174064 [details] [diff] [review]
Patch v.1

Sure.

Comment 8

[Darin Fisher]

fixed-on-trunk