Closed
Bug 281957
Opened 20 years ago
Closed 19 years ago
[FIXr]Remove unneeded prescontext args in the frame constructor
Categories
(Core :: Layout, defect, P1)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
464.63 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
This basically eliminates most of the prescontext/presshell junk that the frame constructor passes around all the time. The patch is, unfortunately, huge. It also depends on the patch to bug 281767. The substantive changes are: 1) Make nsCSSFrameConstructor have an mPresShell member. 2) Remove mFrameConstructor members in some frames (they can get the constructor off the presshell).
|
Assignee | |
Comment 1•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #174062 -
Flags: superreview?(roc)
Attachment #174062 -
Flags: review?(roc)
|
|
Assignee | |
Updated•20 years ago
|
Priority: -- → P1
Summary: Remove unneeded prescontext args in the frame constructor → [FIX]Remove unneeded prescontext args in the frame constructor
Target Milestone: --- → mozilla1.8beta2
Attachment #174062 -
Flags: superreview?(roc)
Attachment #174062 -
Flags: superreview+
Attachment #174062 -
Flags: review?(roc)
Attachment #174062 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Summary: [FIX]Remove unneeded prescontext args in the frame constructor → [FIXr]Remove unneeded prescontext args in the frame constructor
|
|
Assignee | |
Comment 2•19 years ago
|
||
Checked in for 1.8b2. No noticeable perf effect, saved about 1.7k of codesize...
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•