[FIXr]Remove unneeded prescontext args in the frame constructor

RESOLVED FIXED in mozilla1.8beta2

Status

()

P1
normal
RESOLVED FIXED
14 years ago
3 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla1.8beta2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
This basically eliminates most of the prescontext/presshell junk that the frame
constructor passes around all the time.  The patch is, unfortunately, huge.  It
also depends on the patch to bug 281767.  The substantive changes are:

1) Make nsCSSFrameConstructor have an mPresShell member.
2) Remove mFrameConstructor members in some frames (they can get the constructor
   off the presshell).
(Assignee)

Updated

14 years ago
Attachment #174062 - Flags: superreview?(roc)
Attachment #174062 - Flags: review?(roc)
(Assignee)

Updated

14 years ago
Priority: -- → P1
Summary: Remove unneeded prescontext args in the frame constructor → [FIX]Remove unneeded prescontext args in the frame constructor
Target Milestone: --- → mozilla1.8beta2
Attachment #174062 - Flags: superreview?(roc)
Attachment #174062 - Flags: superreview+
Attachment #174062 - Flags: review?(roc)
Attachment #174062 - Flags: review+
(Assignee)

Updated

14 years ago
Summary: [FIX]Remove unneeded prescontext args in the frame constructor → [FIXr]Remove unneeded prescontext args in the frame constructor
(Assignee)

Comment 2

14 years ago
Checked in for 1.8b2.  No noticeable perf effect, saved about 1.7k of codesize...
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Updated

3 months ago
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.