281962 - Flash Block update (current, today is 2-11-2005) fails to install properly and messes up firefox

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[John F Davis]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier:  Firefox/1.0

When I got the update notifier I went ahead and updated, I got an error

Chrome Registration failed for Extension '{3d7eb24f-2740-49df-8937-200b1cc08f8a}'
 when calling nsIXULChromeRegistry::installPackage with this chrome path: 
jar:file:///C:/WINDOWS/Application%20Data/Mozilla/Firefox/Profiles/default.dty/extensions/%
7B3d7eb24f-2740-49df-8937-200b1cc08f8a%7D/chrome/flashblock.jar!/content/flashblock/

(profile extension = true). Perhaps this path does not exist within the chrome
JAR file, or 
the contents.rdf file at that location is malformed?


And suddenly below the status line I had a large chunk of somethign ("Frame
colored something" with some html coding in it "Flash enable" (screen shot in
the compuserve mozilla forum, firefox section, title "latest updates")

I had to do a system restore to get rid of it, then just for testing, brought
everythign up to date EXCEPT firefox and did a system image (Saved backup) then
updated firefox one extension at a time and sure enough, that's the one that did
it (I copied the error from the 2nd attempt) again, a restore fixed it so I'm
running but w/o that update

Computer is a IBM thinkpag 600E fullly expanded memory wise with about 40 gig of
it's 60 Gig hd usable by dos/windows (the rest is used by the recovery software,
Acronis True Image, which once again,,, Saved the day)

Reproducible: Always

Steps to Reproduce:
1.Allow auto update to install the Flash Block update =0r= do so manually from
the tools extension meny
2.Restart firefox
3.

Actual Results:  
I had a bunch of frame colored space below teh status bar with html code in it
refering to "Flash enable" and the like

I also got the error quoted above

Expected Results:  
Updated flash block without changing the appearance of Firefox at all

Disabling/un-installing flash block did not help, Uninstalling and reinstalling
FireFox did not help, Full system restore... Helped

Comment 1

[Anthony M Perez]

An error appears on the bottom of the FireFox user space:

   <menuitem id="context-flahAllow" label="&flashAllow.label;"
----^

Comment 2

[Anthony M Perez]

(In reply to comment #1)
> An error appears on the bottom of the FireFox user space:
> 
>    <menuitem id="context-flahAllow" label="&flashAllow.label;"
> ----^
> 
> 

PS - Also noticed that if the system (PC/WinXP SP2) has Quicktime installed, it
prevents FlashBlock to work. After removing QT from the system and rebooting, it
works fine again, untill the update for FlashBlock "broke" it, causeing the
above error message to display on the bottom of the userspace.

Comment 3

[John F Davis]

I have quick time installed and Flash Block works perfectly... Unless I update
then I geet the very garbage you reported at the bottom of the screen

If anyone wishes to see the screen after update then
http://community.compuerve.com/mozilla and look for a message titled
"latest updates" there is a screen shot attached to the root message
(which is from "John in Detroit" AKA, me)

Oh, and thanks for letting me know I'm not the only one who expierenced it

Comment 4

[Philip Chee]

Attachment: Flashblock install log with chrome registry errors

Flashblock users have been complaining to us about chrome registration errors
with both Mozilla suite (install.js) and Firefox (install.rdf).

These problems only happen if there is a version of flashblock all ready
installed in the profile you are installing to.  Our current workaround is to
uninstall the existing version first.

<http://flashblock.mozdev.org/problems.html>

There appear to be two problems: Registering the content, and registering the
locale.  I'm just guessing wildly but I think there is a race condition between

copying the .jar file into the profile and doing the registration.

For example, if I install the same version over the existing version, I do not
get chrome registry errors when registering locales.  However if I add a locale

to be registered in the install.js script, this is what I get: (see attachment)



The chrome registration fails with the new locale that was not in the previous
.jar file.  In this case it was the es-ES locale

The above is for Mozilla.  For firefox, even when there are chrome registry
errors, the install.log just says:

-------------------------------------------------------------------------------


file:///C:/TEMP/flashblock-test.xpi  --  2005-02-24 20:18:40
-------------------------------------------------------------------------------



     Install completed successfully  --  2005-02-24 20:18:40

but Flashblock dissappears from the list of extensions in the extensions
manager.

[e-mail]
http://flashblock.mozdev.org/

Comment 5

[Philip Chee]

(In reply to comment #1)
> An error appears on the bottom of the FireFox user space:
> 
>    <menuitem id="context-flahAllow" label="&flashAllow.label;"
> ----^
>

Gecko can't find the correct locale/language strings because the locales did not
get registered properly.

Comment 6

[Asa Dotzler [:asa]]

This sounds like a bug in Flashblock. Is it not? If it's not, then please
resummarize this bug to explain the Firefox problem clearly 

Comment 7

[Philip Chee]

Please see bugzilla.mozdev.org bug
<http://bugzilla.mozdev.org/show_bug.cgi?id=9399>
This bug has been resolved as WORKSFORME.

You need to completely uninstall flashblock before installing a new version.
<http://flashblock.mozdev.org/uninstall.html#fbFirefoxNew>

Possible related bugzilla.mozilla.org bug:
<https://bugzilla.mozilla.org/show_bug.cgi?id=248298>
Bug Id 248298 EM fails to delete some extension folders on uninstalling
(flashblock.jar is not deleted on uninstalling)

Comment 8

[Philip Chee]

In Comment #6 Asa Dotzler, wrote:

>This sounds like a bug in Flashblock. Is it not? If it's not, then please
>resummarize this bug to explain the Firefox problem clearly.

I tried to change the summary, but it appears I don't have the privileges to do so.

The core problem is that if there is an existing flashblock.jar file, the
Extension Manager fails to overwrite that with the new version when Firefox
restarts.

Comment 9

[Nickolay_Ponomarev]

Philip, could you post links to the two XPIs that need to be installed (original
& update), and tell me what are the required conditions to reproduce the bug and
whether it's always reproducible - if you know, - I'll try to figure it out. [or
does it only happen on win98? In that case I won't be much of help]

Comment 10

[Philip Chee]

This is on WinXP/SP1. A fellow flashblock developer says he can't reproduce this
on Linux.  Probably due to the way *nix systems delete files (unlink).

Go to <http://downloads.mozdev.org/flashblock/>

1.Download (say) flashblock-1.2.8.xpi and flashblock-1.3.0.1.xpi
2.Create a new clean profile in Firefox.
3.Install 1.2.8.
4.Shutdown and restart several times.
5.Install 1.3.0.1.
6.On restart you get chrome registration errors.
  Depending on the version of firefox, you may only see the errors in the
  console and/or in the JS console.
7.Flashblock disappears from the EM window extension list but still works.
8.If the new version of flashblock has more locales than the previous version
  you may also get the ugly XUL errors at the bottom of the window probably
  because firefox can't find the correct locale .dtd.
  (Firefox trunk builds put this particular error in a separate window)

Anyway once Ben gets through rewriting the EM install/uninstall code this
problem should go away as the new code will rollback everything if an install
fails in the middle.

Comment 11

[Nickolay_Ponomarev]

I can reproduce this with Firefox 1.0, but not with Mozilla/5.0 (Windows; U;
Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050325 Firefox/1.0+

Can you reproduce this with a recent trunk build?

Comment 12

[John F Davis]

I "Solved" the problem (At least for this go round) by uninstalling the old
version of Flash Block and installing clean.

Now.... If the powers that be can please remove me from the notify list

Thank you (I am assuming that whatever the problem is, it will be fixed on the
next update, since the problem has been seen by various users)

Note 1:  I had this problem on my laptop, A Thinkpad 600E running win-98se

I did not risk it on the XP machine

2: I was able to "Roll back" my computer to an earlier date (this is very easy
on a properly backed up computer don't you know) which fixed it, kind of

Comment 13

[Nickolay_Ponomarev]

The uninstall problem (not removing the jar) goes away if I comment out this
line in flashblock.js:
>> addImportToUserStylesheet('userContent.css') 

My guess is that flashblock.jar was locked because of the @import in the
userContent.css, therefore Firefox couldn't neither delete, nor overwrite the
file. I don't have an idea why this doesn't happen in trunk Firefox, but if it
works for you too, let's resolve this as WFM.

--
John, we cannot remove you from the "notify list". You can configure your
settings yourself at https://bugzilla.mozilla.org/userprefs.cgi?tab=email
though. But those settings are global, meaning that you won't get mail related
to your other reports either.

Comment 14

[Philip Chee]

> I don't have an idea why this doesn't happen in trunk Firefox

We use nsIStyleSheetService on the trunk specifically to avoid this problem but
fallback to "addImportToUserStylesheet('userContent.css')" as the stlyesheet
service is not available on FF 1.0.x and Mozilla 1.7.x.

However the Chrome Manager component of the Mnenhy extension *can* remove
flashblock completely even though the .jar file is locked.  Anybody want to dig
throught the Mnenhy code to see what magic they are doing?

P.S. I'm not the original reporter so I can't change this to WFM.

Comment 15

[Nickolay_Ponomarev]

I was talking about 1.2.8, which doesn't have this fallback, so this is *really*
weird. I'm not sure it's because of the file being locked, that was just a
guess. But trunk build works. I'd like to see confirmation of that before
resolving this as WFM.

Comment 16

[Nickolay_Ponomarev]

okay, since nobody appears to be interested in this bug and last time I checked
it worked for me, marking as such. Please reopen if you can reproduce it on a
trunk build.