281974 - [Mac Pinstripe] include text in buttons in Theme and Extension dialogs

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[sairuh (rarely reading bugmail)]

I find that the buttons in the Theme and Extension dialogs are confusing because
they are only images --true, if you hover the mouse just so you'll get a tooltip
with a description. but I think it'd be better/clearer to have text as part of
the button label --perhaps an image+brief text? other 3rd party themes manage to
add this (as does the default Win/Linux theme, iirc).

couldn't find an existing bug, but please dup as needed. am also filing the
equivalent for Thunderbird...

Comment 1

[sairuh (rarely reading bugmail)]

tbird bug is 281975.

Comment 2

[Mike Connor [:mconnor]]

I think we did this on purpose, Kevin, this is a good point, but if its wrong on
Mac, then we can wontfix and move on.

Comment 3

[Kevin Gerich]

I agree, this is a problem. I was following the Mac convention of the control
buttons seen in Mac Mail.app and elsewhere. I'd like to try a bevel button with
just text inside, no graphic...

Comment 4

[Benjamin Smedberg]

http://lxr.mozilla.org/mozilla/source/toolkit/themes/pinstripe/mozapps/extensions/extensions.css#119

Comment 5

[Kevin Gerich]

Attachment: Cleans up Extension and Download windows.

This patch cleans up the Extensions and the Downloads windows. I agree that the
buttons with images and no text were confusing. This patch turns them into
bevel buttons with text only, no images.

Fixes the following bugs: 

Bugzilla Bug 281974 + 281975 [Mac Pinstripe] include text in buttons in Theme
and Extension dialogs
Bugzilla Bug 300414 Better visual indication that extension is to be
uninstalled
Bugzilla Bug 300040 download manager cleanup button ("X") is confusing

modified files:

mozappps/extensions/extensions.css
mozapps/jar.mn
mozapps/downloads/downloads.css

additions:

mozilla/toolkit/themes/pinstripe/mozapps/downloads/background-stripe.gif
mozilla/toolkit/themes/pinstripe/mozapps/downloads/background-gradient.gif

removals:

mozilla/toolkit/themes/pinstripe/mozapps/downloads/cleanup-button-disabled.png
mozilla/toolkit/themes/pinstripe/mozapps/downloads/cleanup-button-pressed.png
mozilla/toolkit/themes/pinstripe/mozapps/downloads/cleanup-button.png
mozilla/toolkit/themes/pinstripe/mozapps/downloads/options-button-pressed.png
mozilla/toolkit/themes/pinstripe/mozapps/downloads/options-button.png
mozilla/toolkit/themes/pinstripe/mozapps/downloads/background-stripe.png
mozilla/toolkit/themes/pinstripe/mozapps/downloads/background-gradient.png
mozilla/toolkit/themes/pinstripe/mozapps/extensions/actionbuttons.png
mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensionOptions-pressed.png

mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensionOptions.png

Comment 6

[Kevin Gerich]

checked in on branchg and trunk

Comment 7

[Marcia Knous [:marcia]]

Looks good using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
rv:1.8b5) Gecko/20050927 Firefox/1.4. Adding verified keyword.