281980 - TBTrunk crash marking junk mail [@ nsScanner::ReadUntil]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jay Patel [:jay]]

Couldn't find a component for filter/junk mail, so marking selecting general.  A
few users have been crashing with recent ThunderbirdTrunk builds marking
messages as junk mail.  Here is the latest from Talkback:

Count   Offset    Real Signature
[ 5   nsScanner::ReadUntil 2c4cfa31 - nsScanner::ReadUntil ]
 
     Crash date range: 01-FEB-05 to 03-FEB-05
     Min/Max Seconds since last crash: 11 - 65435
     Min/Max Runtime: 51542 - 152763
 
     Count   Platform List 
     4   Windows XP [Windows NT 5.1 build 2600] 
     1   Windows 2K [Windows NT 5.0 build 2195] 
 
     Count   Build Id List 
     5   2005013005
 
     No of Unique Users         2
 
 Stack trace(Frame) 

	 nsScanner::ReadUntil
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsScanner.cpp
 line 1273] 
	 CTextToken::Consume
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsHTMLTokens.cpp
 line 589] 
	 nsHTMLTokenizer::ConsumeText
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsHTMLTokenizer.cpp
 line 1008] 
	 nsHTMLTokenizer::ConsumeTag
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsHTMLTokenizer.cpp
 line 600] 
	 nsHTMLTokenizer::ConsumeToken
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsHTMLTokenizer.cpp
 line 491] 
	 nsParser::Tokenize
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsParser.cpp
 line 2728]  
 
     (3476058)	Comments: Looked at  an e-Mail labeled as junk but still in
Inbasket (That happens 50% of time - some go to trash  some don't).  Clicked it
to make it 'not junk'  TB puked.    BTW:  Message filters do nothing
automatically  but when run by hand they sometimes work.
     (3476058)	Comments:   Gettings to match (rule to actual) is a B****H.
     (3429673)	Comments: Marking message as junk
     (3429361)	Comments: Marking messages as junk (again)
     (3429333)	Comments: Marking messages as junk
     (3429309)	Comments: Marking messages as junk
 
====================================================================================================
     Count   Offset    Real Signature
[ 1   nsScanner::ReadUntil 2da955ef - nsScanner::ReadUntil ]
 
     Crash date range: 01-FEB-05 to 01-FEB-05
     Min/Max Seconds since last crash: 1630 - 1630
     Min/Max Runtime: 1630 - 1630
 
     Count   Platform List 
     1   Windows XP [Windows NT 5.1 build 2600] 
 
     Count   Build Id List 
     1   2005013106
 
     No of Unique Users         1
 
 Stack trace(Frame) 

	 nsScanner::ReadUntil
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsScanner.cpp
 line 1273] 
	 CTextToken::Consume
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsHTMLTokens.cpp
 line 589] 
	 nsHTMLTokenizer::ConsumeText
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsHTMLTokenizer.cpp
 line 1008] 
	 nsHTMLTokenizer::ConsumeTag
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsHTMLTokenizer.cpp
 line 600] 
	 nsHTMLTokenizer::ConsumeToken
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsHTMLTokenizer.cpp
 line 491] 
	 nsParser::Tokenize
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsParser.cpp
 line 2728] 
	 nsParser::Tokenize
[e:/builds/tinderbox/thunderbird-trunk/WINNT_5.0_Clobber/mozilla/parser/htmlparser/src/nsParser.cpp
 line 2720]  
 
And a link to all current nsScanner::ReadUntil bugs:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=nsScanner%3A%3AReadUntil&vendor=All&product=All&platform=All&buildid=&sdate=&stime=&edate=&etime=&sortby=bbid

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Jay, since this crash is in htmlparser code, it probably should have found a CC
or assignment there. I also notice that the last build to crash is
MozillaOrgThunderbirdTrunkWin322005013106 (2005-01-31-06) which coincides with
my checkin for bug 280079, which was a bug that certainly could have caused a
crash with the stack trace that this bug shows.

Unless I'm missing something, shouldn't this bug be FIXED?

Comment 2

[Scott MacGregor]

I agree with Kaplan, this bug looks to be fixed given recent talk back data.