suspicious reminder of bug 163614

RESOLVED FIXED

Status

()

RESOLVED FIXED
14 years ago
11 years ago

People

(Reporter: bernd_mozilla, Assigned: bernd_mozilla)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
bug 163614 changed 

DeleteChildsNextInFlow to DeleteNextInFlowChild

so the DeleteChildsNextInFlow was intended to overwrite the ContainerFrame
implementation.

now the outer table frame does not overwrite the ContainerFrame implementation.

Task 1 Investigate why the outer table frame needed that function as the code 
       claims
Task 2 If it is really necessary find a case where it breaks
Task 3 fix it
(Assignee)

Comment 1

11 years ago
Created attachment 290119 [details] [diff] [review]
patch to remove dead code

I am not aware of any situation where we need this. If this goes wrong it will crash. There hasn't been such a crash for a long time.
Attachment #290119 - Flags: superreview?(roc)
Attachment #290119 - Flags: review?(roc)
Attachment #290119 - Flags: superreview?(roc)
Attachment #290119 - Flags: superreview+
Attachment #290119 - Flags: review?(roc)
Attachment #290119 - Flags: review+
(Assignee)

Comment 2

11 years ago
Comment on attachment 290119 [details] [diff] [review]
patch to remove dead code

we did not call this code for ages.
Attachment #290119 - Flags: approval1.9?

Updated

11 years ago
Attachment #290119 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 3

11 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.