Closed
Bug 282009
Opened 20 years ago
Closed 17 years ago
suspicious reminder of bug 163614
Categories
(Core :: Layout: Tables, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bernd_mozilla, Assigned: bernd_mozilla)
References
()
Details
Attachments
(1 file)
|
4.14 KB,
patch
|
roc
:
review+
roc
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
bug 163614 changed
DeleteChildsNextInFlow to DeleteNextInFlowChild
so the DeleteChildsNextInFlow was intended to overwrite the ContainerFrame
implementation.
now the outer table frame does not overwrite the ContainerFrame implementation.
Task 1 Investigate why the outer table frame needed that function as the code
claims
Task 2 If it is really necessary find a case where it breaks
Task 3 fix it
I am not aware of any situation where we need this. If this goes wrong it will crash. There hasn't been such a crash for a long time.
Attachment #290119 -
Flags: superreview?(roc)
Attachment #290119 -
Flags: review?(roc)
Attachment #290119 -
Flags: superreview?(roc)
Attachment #290119 -
Flags: superreview+
Attachment #290119 -
Flags: review?(roc)
Attachment #290119 -
Flags: review+
Comment on attachment 290119 [details] [diff] [review]
patch to remove dead code
we did not call this code for ages.
Attachment #290119 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #290119 -
Flags: approval1.9? → approval1.9+
fix checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•