282022 - Layout regression tests not working under Windows?

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Frank Wein [:mcsmurf]]

I discovered that the regression tests were not working under Windows, the
reason was a missing / at the end of the path for the obj-dir in the .mozconfig.
But AFAIK the path for the obj-dir specified in the .mozconfig normally never
ends with a /, also http://www.mozilla.org/build/configure-build.html shows for
example "MOZ_OBJDIR=@TOPSRCDIR@/suite-opt" or
"MOZ_OBJDIR=@TOPSRCDIR@/some_subdir". I'm attaching a potential patch.
As far as i see this, this would have been broken on Linux with a obj-dir, too.
Or do you Layout hackers use a different .mozconfig (or hacked rtest.sh) :)?

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

This also fixes another problem, without the patch it replaced @CONFIG-GUESS@
for example in
obj-@CONFIG_GUESS@-debug
with this
obj-i686-pc-cygwin/-debug
With the patch it changes it to
obj-i686-pc-cygwin-debug

bernd: You own blame for that :), do you know why you changed the code like it
is atm?

Comment 2

[Bernd]

>bernd: You own blame for that :), do you know why you changed the code like it
is atm?
because it WFM's like it is now

E:\moz_src\mozilla\layout\html\tests\block>cvs diff rtest.sh

E:\moz_src\mozilla\layout\html\tests\block>

second this code is nearly obsolote and replaced by the regression tests runned
from the layoutdebugger.

The only reason it still exists are printing regression tests which can not be
executed from the layoutdebugger up to now.

Comment 3

[Mats Palmgren (inactive)]

Frank, see bug 215112 comment 8 - 10.

Comment 4

[Frank Wein [:mcsmurf]]

(In reply to comment #3)
> Frank, see bug 215112 comment 8 - 10.

But as long as the code is in CVS and it is still needed (also if it is only for
a small part of Mozilla), i think fixes should be reviewed and checked in.

Comment 5

[Bernd]

Comment on attachment 174129 [details] [diff] [review]
Patch

This file is obsolete. I just removed the documentation referencing this file.
And soon this file we be deleted too.

Comment 6

[Frank Wein [:mcsmurf]]

ok.