Closed
Bug 282025
Opened 20 years ago
Closed 18 years ago
Queries with group pronouns should accept non-word characters in group names
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: bugreport, Assigned: justdave)
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
bugreport
:
review+
|
Details | Diff | Splinter Review |
Group names can have characters that are outside of the set matched by the \w regexp metachar. Pronouns should be able to use any valid group name.
|
Assignee | |
Comment 2•18 years ago
|
||
Looking at editgroups.cgi, it appears that darn near anything is legal in a group name. That makes life difficult, so I basically just changed the regexp to look for anything other than a % character (since the % closes the pronoun).
|
Reporter | |
Comment 3•18 years ago
|
||
Comment on attachment 227043 [details] [diff] [review] Patch v1 r=joel I am having problems with runtests on my system (unreleated to this) Make sure it runs clean before landing this.
Attachment #227043 -
Flags: review?(bugreport) → review+
|
|
Reporter | |
Updated•18 years ago
|
Flags: approval?
|
||
Updated•18 years ago
|
Flags: approval? → approval+
|
||
Comment 4•18 years ago
|
||
Checking in Bugzilla/Search.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v <-- Search.pm new revision: 1.133; previous revision: 1.132 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
OS: Windows ME → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.24
You need to log in
before you can comment on or make changes to this bug.
Description
•