Closed
Bug 282031
Opened 15 years ago
Closed 15 years ago
[BEOS] Our nsToolkit::CallMethod is broken
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: thesuckiestemail, Assigned: thesuckiestemail)
References
Details
Attachments
(2 files, 3 obsolete files)
|
8.64 KB,
patch
|
sergei_d
:
review+
|
Details | Diff | Splinter Review |
|
658 bytes,
patch
|
sergei_d
:
review+
dougt
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8b) Gecko/20050212 Firefox/1.0+ Build Identifier: nsAppShell and nsToolkit uses a sync-semaphore to halt and wake up threads that wants to do work in the GUI-thread. This is slow and there is no guarantee the thread whose work was just processed is the one woken up. Instead I suggest we pass the thread id in the call and then suspend the thread. When the work is processed the GUI-thread wakes it up with a resume_thread. Patch in progress. Reproducible: Always
Tried to clean it up a little.
Attachment #174144 -
Attachment is obsolete: true
r?
Attachment #174148 -
Attachment is obsolete: true
Attachment #174150 -
Flags: review?(sergei_d)
Some of the changes are in unreachable nsToolkit-code, but I have a feeling I'm going to do some work there soon :)
Attachment #174150 -
Attachment is obsolete: true
Attachment #174150 -
Flags: review?(sergei_d)
Comment 6•15 years ago
|
||
Comment on attachment 174150 [details] [diff] [review] Spotted some formatting things. Works great. r=sergei_d
Attachment #174150 -
Flags: review+
As there is a small change in xpcom now I'm switching to xpcom-component.
Component: GFX: BeOS → XPCOM
Comment on attachment 174151 [details] [diff] [review] xpcom/threads/plevent.c did actually know about this too Better put a review on the lines in xpcom as well. r?
Attachment #174151 -
Flags: review?(sergei_d)
Comment 9•15 years ago
|
||
tqh, putting plevent change in same patch will cause need for sr also for widget/src/beos changes:)
Comment 10•15 years ago
|
||
Comment on attachment 174151 [details] [diff] [review] xpcom/threads/plevent.c did actually know about this too r=sergei_d actually, same as previous. Need someone's help for sr and checkin, as now patch touches xpcom
Attachment #174151 -
Flags: review?(sergei_d) → review+
| Assignee | ||
Comment 11•15 years ago
|
||
Should I seperate them?
| Assignee | ||
Comment 12•15 years ago
|
||
Ok, so to easier get SR we do this.
Attachment #174212 -
Flags: review?(sergei_d)
| Assignee | ||
Comment 13•15 years ago
|
||
Comment on attachment 174150 [details] [diff] [review] Spotted some formatting things. We'll use this one.
Attachment #174150 -
Attachment is obsolete: false
| Assignee | ||
Comment 14•15 years ago
|
||
Comment on attachment 174151 [details] [diff] [review] xpcom/threads/plevent.c did actually know about this too And not this one, they are identical, except for xpcom/threads/plevent.c which is in last patch now.
Attachment #174151 -
Attachment is obsolete: true
Comment 15•15 years ago
|
||
Comment on attachment 174212 [details] [diff] [review] Changes outside BeOS-folder (plevent.c) r=sergei_d
Attachment #174212 -
Flags: review?(sergei_d) → review+
| Assignee | ||
Comment 16•15 years ago
|
||
Comment on attachment 174212 [details] [diff] [review] Changes outside BeOS-folder (plevent.c) sr? (This is BeOS only changes in our nsAppShell / nsToolkit, but since plevent.c knows about this as well we want that fixed. So we're doing sr on that part.)
Attachment #174212 -
Flags: superreview?(dougt)
Comment 17•15 years ago
|
||
Comment on attachment 174212 [details] [diff] [review] Changes outside BeOS-folder (plevent.c) look fine. need a checkin?
Attachment #174212 -
Flags: superreview?(dougt) → superreview+
| Assignee | ||
Comment 18•15 years ago
|
||
Yes, it would be great if you could checkin both patches, but isn't the tree frozen for 1.8b?
Comment 19•15 years ago
|
||
last patch checked in: Checking in plevent.c; /cvsroot/mozilla/xpcom/threads/plevent.c,v <-- plevent.c new revision: 1.50; previous revision: 1.49 done
| Assignee | ||
Comment 20•15 years ago
|
||
Sergei, plevent.c is checked in, so could you check in our widget changes?
Comment 21•15 years ago
|
||
Do you mean this https://bugzilla.mozilla.org/attachment.cgi?id=174150 one?
| Assignee | ||
Comment 22•15 years ago
|
||
yes.
Comment 23•15 years ago
|
||
Done. Checked in 2005-02-19 11:54 'bug 282031. Use suspend/resume_thread instead syncsem for synchronous events. r=sergei_d. no sr required - BeOS-only'
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•