Last Comment Bug 282031 - [BEOS] Our nsToolkit::CallMethod is broken
: [BEOS] Our nsToolkit::CallMethod is broken
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: Other BeOS
: -- normal (vote)
: ---
Assigned To: tqh
: QA timeless
Mentors:
Depends on:
Blocks: 266252
  Show dependency treegraph
 
Reported: 2005-02-12 06:13 PST by tqh
Modified: 2005-02-20 02:49 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Old patch, until I've made the real one. Should work though. (7.07 KB, patch)
2005-02-12 06:18 PST, tqh
no flags Details | Diff | Review
Cleaned up patch (8.65 KB, patch)
2005-02-12 06:39 PST, tqh
no flags Details | Diff | Review
Spotted some formatting things. (8.64 KB, patch)
2005-02-12 06:44 PST, tqh
sergei_d: review+
Details | Diff | Review
xpcom/threads/plevent.c did actually know about this too (9.56 KB, patch)
2005-02-12 07:10 PST, tqh
sergei_d: review+
Details | Diff | Review
Changes outside BeOS-folder (plevent.c) (658 bytes, patch)
2005-02-13 06:18 PST, tqh
sergei_d: review+
dougt: superreview+
Details | Diff | Review

Description tqh 2005-02-12 06:13:06 PST
User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8b) Gecko/20050212 Firefox/1.0+
Build Identifier: 

nsAppShell and nsToolkit uses a sync-semaphore to halt and wake up threads that
wants to do work in the GUI-thread. This is slow and there is no guarantee the
thread whose work was just processed is the one woken up.

Instead I suggest we pass the thread id in the call and then suspend the thread.
When the work is processed the GUI-thread wakes it up with a resume_thread.

Patch in progress.

Reproducible: Always
Comment 1 tqh 2005-02-12 06:18:10 PST
Created attachment 174144 [details] [diff] [review]
Old patch, until I've made the real one. Should work though.
Comment 2 tqh 2005-02-12 06:39:17 PST
Created attachment 174148 [details] [diff] [review]
Cleaned up patch

Tried to clean it up a little.
Comment 3 tqh 2005-02-12 06:44:10 PST
Created attachment 174150 [details] [diff] [review]
Spotted some formatting things.

r?
Comment 4 tqh 2005-02-12 06:45:17 PST
Some of the changes are in unreachable nsToolkit-code, but I have a feeling I'm
going to do some work there soon :)
Comment 5 tqh 2005-02-12 07:10:44 PST
Created attachment 174151 [details] [diff] [review]
xpcom/threads/plevent.c did actually know about this too

Fixed the types in plevent.c
Comment 6 Sergei Dolgov 2005-02-12 07:15:10 PST
Comment on attachment 174150 [details] [diff] [review]
Spotted some formatting things.

Works great.
r=sergei_d
Comment 7 tqh 2005-02-12 07:52:58 PST
As there is a small change in xpcom now I'm switching to xpcom-component.
Comment 8 tqh 2005-02-12 07:53:50 PST
Comment on attachment 174151 [details] [diff] [review]
xpcom/threads/plevent.c did actually know about this too

Better put a review on the lines in xpcom as well. r?
Comment 9 Sergei Dolgov 2005-02-12 08:00:35 PST
tqh, putting plevent change in same patch will cause need for sr also for
widget/src/beos changes:)
Comment 10 Sergei Dolgov 2005-02-12 08:03:24 PST
Comment on attachment 174151 [details] [diff] [review]
xpcom/threads/plevent.c did actually know about this too

r=sergei_d

actually, same as previous.

Need someone's help for sr and checkin, as now patch touches xpcom
Comment 11 tqh 2005-02-13 01:23:51 PST
Should I seperate them?
Comment 12 tqh 2005-02-13 06:18:14 PST
Created attachment 174212 [details] [diff] [review]
Changes outside BeOS-folder (plevent.c)

Ok, so to easier get SR we do this.
Comment 13 tqh 2005-02-13 06:20:40 PST
Comment on attachment 174150 [details] [diff] [review]
Spotted some formatting things.

We'll use this one.
Comment 14 tqh 2005-02-13 06:21:41 PST
Comment on attachment 174151 [details] [diff] [review]
xpcom/threads/plevent.c did actually know about this too

And not this one, they are identical, except for xpcom/threads/plevent.c which
is in last patch now.
Comment 15 Sergei Dolgov 2005-02-13 06:43:32 PST
Comment on attachment 174212 [details] [diff] [review]
Changes outside BeOS-folder (plevent.c)

r=sergei_d
Comment 16 tqh 2005-02-13 07:02:33 PST
Comment on attachment 174212 [details] [diff] [review]
Changes outside BeOS-folder (plevent.c)

sr?

(This is BeOS only changes in our nsAppShell / nsToolkit, but since plevent.c
knows about this as well we want that fixed. So we're doing sr on that part.)
Comment 17 Doug Turner (:dougt) 2005-02-14 11:15:35 PST
Comment on attachment 174212 [details] [diff] [review]
Changes outside BeOS-folder (plevent.c)

look fine.  need a checkin?
Comment 18 tqh 2005-02-14 12:54:10 PST
Yes, it would be great if you could checkin both patches, but isn't the tree
frozen for 1.8b?
Comment 19 Doug Turner (:dougt) 2005-02-19 10:42:54 PST
last patch checked in:

Checking in plevent.c;
/cvsroot/mozilla/xpcom/threads/plevent.c,v  <--  plevent.c
new revision: 1.50; previous revision: 1.49
done
Comment 20 tqh 2005-02-19 11:15:57 PST
Sergei, plevent.c is checked in, so could you check in our widget changes?
Comment 21 Sergei Dolgov 2005-02-19 11:38:14 PST
Do you mean this
https://bugzilla.mozilla.org/attachment.cgi?id=174150
one?
Comment 22 tqh 2005-02-19 11:39:52 PST
yes.
Comment 23 Sergei Dolgov 2005-02-19 11:57:02 PST
Done.
Checked in 2005-02-19 11:54 'bug 282031. Use suspend/resume_thread instead
syncsem for synchronous events. r=sergei_d. no sr required - BeOS-only'

Note You need to log in before you can comment on or make changes to this bug.


Privacy Policy