282050 - browser.xul.error_pages.enabled should take effect immediately in the same window/tab

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Frank Wein [:mcsmurf]]

When you change the value of browser.xul.error_pages.enabled, it only takes
effect after the next restart. It should take effect immediately.

Comment 1

[Justin Kerk]

WFM (takes effect immediately) with Mozilla/5.0 (Windows; U; Windows NT 5.0;
en-US; rv:1.8b2) Gecko/20050224 Firefox/1.0+

Comment 2

[José Jeria]

WFM as well:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050224
Firefox/1.0+

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

er, this works for you two in currently opened windows/tabs?

Comment 4

[Justin Kerk]

Hmm actually no, it won't work in the same tab that I change the pref in but if
I open a new tab it works there. That's not what the summary describes though.
Morph the bug?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

my understanding is that this bug always was about that problem, but anyway,
let's use it for that one.

Comment 6

[Fred Collier]

A change to "browser.xul.error_pages.enabled" does indeed take effect
immediately.  But note that if you set it to "false", a restart of FF always
returns it to "true".  Apparently "true" is the only acceptable state, and
"false" is only allowed temporarily.

Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8b2) Gecko/20050316 Firefox/1.0+

Comment 7

[José Jeria]

(In reply to comment #6)
> A change to "browser.xul.error_pages.enabled" does indeed take effect
> immediately.  But note that if you set it to "false", a restart of FF always
> returns it to "true".

This is bug 286553

Comment 8

[Fred Collier]

Forget my last comment! I had an error in my user.js file.

Comment 9

[Aaron Leventhal]

This caused bug 300864

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

aaron: there is no patch on this bug...

Comment 11

[Aaron Leventhal]

(In reply to comment #10)
> aaron: there is no patch on this bug...

Okay, wrong bug. Whichever bug was used to turn on XUL error pages caused the
problem.

Comment 12

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.1

It says in [e-mail]'s bugzilla name "not reading bugs". I'm guessing
that he still does reviews, so requesting review from him.

It seems docshells are pretty static regarding prefs, so when we add observing
for one, maybe we should observe the others as well? That'd be a new bug in any
case.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 196144 [details] [diff] [review]
version 0.1

biesi, could you take a look at this?  I won't be able to for a good long
while....  If you don't have time either, just punt back to me, I guess.

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 196144 [details] [diff] [review]
version 0.1

yes, I think docshell should observe the other prefs too.


+    if (!nsCRT::strcmp(aTopic, NS_PREFBRANCH_PREFCHANGE_TOPIC_ID) &&
+	 !nsCRT::strcmp(aData,
+	   NS_LITERAL_STRING("browser.xul.error_pages.enabled").get()) &&
+	 mObserveErrorPages) {

you should move the mObserveErrorPages check first, since it's fastest to check

r=biesi with that; thanks for the patch!

Comment 15

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.2

biesi: Thanks!

When we're done with this bug, I'll file a new one about removing the mPrefs
member from docshell altogether, and make use of pref observers instead.

Comment 16

[Johnny Stenback (:jst)]

Comment on attachment 196598 [details] [diff] [review]
version 0.2

sr=jst

Comment 17

[Vidar Haarr (not reading bugmail)]

biesi: Think you could help me check this in?

Filed bug 309654.

Comment 18

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in docshell/base/nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.743; previous revision: 1.742
done
Checking in docshell/base/nsDocShell.h;
/cvsroot/mozilla/docshell/base/nsDocShell.h,v  <--  nsDocShell.h
new revision: 1.191; previous revision: 1.190
done