282078 - Minor fixes for upcoming Welsh Firefox 1.0.1

Status: RESOLVED FIXED

(Mozilla Localizations :: Other, defect)

Description

[Dewi Jones]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; cy-GB; rv:1.7.3) Gecko/20040910
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; cy-GB; rv:1.7.3) Gecko/20040910


We have completed first round of QA'ing the upcoming Welsh localisation of
Firefox (1.0.1). Builds we tested were:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-aviary1.0-l10n/

All functionality works in Windows, Linux and Mac.

However, we would like to have some patches checked into CVS. They are merely
linguistic fixes - spelling and terminological consistency. The number of files
will have been kept to an absolute minimum. They have been tested by us and
passed all our checks fine.

We have an improved bookmarks.html with links to instead to Welsh newsfeeds from
the BBC and Welsh pages for Mozilla-Europe.org (translations to be sent to the
startpages email address).




Reproducible: Always

Comment 1

[Dewi Jones]

Attachment: Updated files for cy-GB CVS checkin

The files contained in this zip need to be used to update/replace those
currently in Mozilla CVS. 

Paths to the files in the ZIP match those in CVS.

Comment 2

[Dewi Jones]

Adding Axel and Gandalf for reviewing fixes. 

(since I haven't yet got CVS access (270208) could you also, if you're happy
with the updates, check them in also?)

Thanks for all your help so far!!!!! I hope I've submitted the patch in as
convenient a form as possible for you. 

Welsh Firefox will get a very warm welcome in the hillsides and valleys of
Wales. Diolch yn fawr!

Comment 3

[Axel Hecht]

Comment on attachment 174181 [details]
Updated files for cy-GB CVS checkin 

Please provide a diff, created with
cvs -z3 diff -u
That is much better for review.
Don't use the approval-aviary1.0.1 flag, please.

Comment 4

[Dewi Jones]

Attachment: CVS diffs of cy-GB patches

Sorry about that. Attached is the output from "cvs -z3 diff -u" command.

Diolch!

Comment 5

[Axel Hecht]

Comment on attachment 174246 [details] [diff] [review]
CVS diffs of cy-GB patches

a=me with the following changes to bookmarks.html:
Please keep the link to spreadfirefox, and remove the link to meddal.com. The
latter isn't really a Mozilla or Firefox link.

Comment 6

[Dewi Jones]

Attachment: Corrected patches for upcoming Welsh Firefox

Sorry again.

Here are all the diffs again, but with corrections to bookmarks.html. 

The translations for the mozilla-europe, which will refer to Meddal.com, are on
their way. 

Cheers!!
Dewi.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 174181 [details]
Updated files for cy-GB CVS checkin 

This should be asking for approval-l10n, not approval-aviary1.0.1

Comment 8

[Dewi Jones]

Doh. Sorry. 

Just to check, is this why I can't see these fixes in the latest cy-GB builds
(from Feb 18) so far in
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-aviary1.0.1-l10n/ ?

Bugzilla 270208 means I can't check anything in yet, so I need Axel or Gandalf
to do the honours for me.

Cheers,
Dewi

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 174332 [details] [diff] [review]
Corrected patches for upcoming Welsh Firefox

checked in

Comment 10

[sairuh (rarely reading bugmail)]

confirming since this has reviewed and checked in patches. :)

Comment 11

[Axel Hecht]

Once stuff is checked in, bugs are fixed. Hopefully.