282080 - The opacity property does not work for images on Mac

Status: RESOLVED DUPLICATE of bug 283343

(Core :: Web Painting, defect)

Description

[Hiro]

In the test case of URL, opacity doesn't work. 
https://bugzilla.mozilla.org/show_bug.cgi?id=228441#c27

However, opacity to the character works. 

It seems to work in build to 2005/02/10 according to the following comments. 
https://bugzilla.mozilla.org/show_bug.cgi?id=228441#c28

Of course, there is no problem in Mozilla1.7.x. 

Mac OS X 10.3.8
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b) Gecko/20050212
and
trunk Camino 2005021220 (v0.8+)

Comment 1

[Anne (:annevk)]

This works on Windows (XP) using 2005021223.

Comment 2

[HARUNAGA Hirotoshi]

My comment in bug 228441 comment 28 is wrong, in which I only said
the image was visible...

2004102906/Mac has no problem.
2004111207/Mac is broken.

Comment 3

[Boris Zbarsky [:bzbarsky]]

I don't see any obvious smoking guns in the range listed in comment 2... is it
at all possible to narrow the range?

Comment 4

[jhp (no longer active)]

Using Firefox builds at archive.mozilla.org, I narrowed it down to between
2004110307 (good) and 2004110411 (bad).

Comment 5

[jhp (no longer active)]

Attachment: patch

As mentioned by roc https://bugzilla.mozilla.org/show_bug.cgi?id=228399#c81, we
should be using srcSpan instead of srcRowBytes.  This fixed the issue for me.

Comment 6

[Simon Fraser [no longer active]]

Nice catch.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Actually I'm afraid that this patch might break other platforms due to
compensating bugs in those platforms having their bytes swapped :-(

see bug 283343

Comment 8

[Sergei Dolgov]

Yeah, definitely dup of 283343
(or vice versa:).
Just didn't know that someone already discovered problem which i supposed to
mayhappen.

Comment 9

[Sergei Dolgov]

As bug 283343 explains real reason of the problem, marking this one as dup

*** This bug has been marked as a duplicate of 283343 ***