282128 - query.cgi: Eliminate deprecated Bugzilla::DB routines

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Max Kanat-Alexander]

Time to tackle this page, now. Shouldn't be too hard, really.

Comment 1

[Max Kanat-Alexander]

Attachment: Remove SendSQL calls from query.cgi

Comment 2

[Frédéric Buclin]

Comment on attachment 174230 [details] [diff] [review]
Remove SendSQL calls from query.cgi

>+                my $query = $dbh->selectrow_array(
>+                    "SELECT query FROM namedqueries " .
>+                     "WHERE userid = ? AND name = ?",
>+                     undef, ($userid, $name));

Here, we select the query which has the $name name...

>                 if (!$query) {
>-                    SendSQL("INSERT INTO namedqueries " .
>+                    $dbh->do("INSERT INTO namedqueries " .
>                             "(userid, name, query) VALUES " .
>-                            "($userid, $qname, " . SqlQuote($value) . ")");
>+                            "(?, ?, ?)", undef, ($userid, $name, $query));
>                 }

... If this query does not exist yet, we add its $value to the DB! Why do you
replace $value by $query??

Comment 3

[Max Kanat-Alexander]

Attachment: v2

OK, fixed that bit. :-)

Comment 4

[Frédéric Buclin]

Comment on attachment 174482 [details] [diff] [review]
v2

r=LpSolit

Comment 5

[Max Kanat-Alexander]

I checked this in even though it technically still has LOCK TABLES statements
inside of it. That will get handled when Tomas makes a new patch for the LOCK
TABLES bug.

Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.139; previous revision: 1.138
done