Closed
Bug 282141
Opened 20 years ago
Closed 19 years ago
Use system colors pref uses the wrong color for default background
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: caillon, Assigned: caillon)
References
Details
Attachments
(1 file, 1 obsolete file)
1.25 KB,
patch
|
dbaron
:
review+
dmosedale
:
superreview+
|
Details | Diff | Splinter Review |
We should use base, not bg. Patch coming.
Assignee | ||
Comment 1•20 years ago
|
||
Use base, and get rid of an extra assignment of aColor (it gets assigned 0 in the default: branch of the switch)
Attachment #174243 -
Flags: superreview?(blizzard)
Attachment #174243 -
Flags: review?(marco)
Updated•20 years ago
|
Attachment #174243 -
Flags: review?(marco) → review+
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 174243 [details] [diff] [review] Patch blizzard says sr=blizzard (looking over my shoulder)
Attachment #174243 -
Flags: superreview?(blizzard) → superreview+
Assignee | ||
Comment 3•20 years ago
|
||
Comment on attachment 174243 [details] [diff] [review] Patch Let's get this for 1.8b, and the branches.
Attachment #174243 -
Flags: approval1.8b?
Attachment #174243 -
Flags: approval1.7.6?
Attachment #174243 -
Flags: approval-aviary1.0.1?
Comment 4•20 years ago
|
||
Comment on attachment 174243 [details] [diff] [review] Patch a=asa for 1.8b. Will evaluage with other drivers for the branches.
Attachment #174243 -
Flags: approval1.8b? → approval1.8b+
Assignee | ||
Comment 5•20 years ago
|
||
this only affects when the pref is set to "use system colors", which it is not by default. I flip this on in my RPMs in rawhide and would like to move it over to FC3 RPMs, but the pref currently makes top sites such as yahoo.com look quite bad because of this bug.
Assignee | ||
Comment 6•20 years ago
|
||
Fixed on trunk
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
This patch looks wrong to me. WindowBackground and WindowText should correspond, which means they should either be bg and fg or base and text.
Comment 8•20 years ago
|
||
Good point. I think they should be base and text.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 174243 [details] [diff] [review] Patch This version shouldn't go in for a final release; we'll consider the fixed version when it's ready.
Attachment #174243 -
Flags: approval1.7.6?
Attachment #174243 -
Flags: approval1.7.6-
Attachment #174243 -
Flags: approval-aviary1.0.1?
Attachment #174243 -
Flags: approval-aviary1.0.1-
Assignee | ||
Comment 10•19 years ago
|
||
Against the previous version, for completeness (and for branches? -- too late for the 1.0.1/1.7.6 set of releases, but for the next ones?)
Attachment #174243 -
Attachment is obsolete: true
Attachment #175183 -
Flags: review+
Updated•19 years ago
|
Attachment #175183 -
Flags: superreview+
Assignee | ||
Comment 11•19 years ago
|
||
Checked in the remaining portion of the patch 2005-03-08 13:54.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•