282144 - [Submission] Detect change of GUID

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

At least 3% of authors change their GUID, perhaps without understanding its
purpose.  We should detect whether the same author has submitted an extension by
the same name with a different GUID and give them the opportunity to cancel
their update.  There is currently no indication that the GUID has changed today.
 The only way I notice is that I am an Admin and it tries to create it under my
email address.

Comment 1

[Giorgio GA]

In some case the GUID change is necessary (e.g. when a valid GUID in firefox is
refused by deer park - try {ff1f5c85-cc94-de02-c1f-423e25cca685}).

When this happens, the author should be able to remove the previous version and
then upload the new one.

If this is not possible, there should be at least a way to desupport an
extension (a delete button on the site?).

Comment 2

[alanjstr]

You should be able to delete the extension from the site.  However, this need
does arise occasionally, due to conflicts and problems with the original upload.

Comment 3

[Michael Morgan [:morgamic]]

Mass change - bugs to be read / (re)confirmed.

Comment 4

[Cameron]

AMO bugspam. Correcting QA contacts on OLD bugs ([e-mail])

-> Correct QA contact ([e-mail])

Filtermeplzkthx

Comment 5

[Cameron]

reconfirming, authors should be notified of this, although still allowed to actually do it probably.

Comment 7

[Justin Scott [:fligtar]]

I'm going to call this fixed in 3.5. Until now, there was no real difference between the submit new add-on page and the update add-on page. If you submitted a new add-on as an update to another add-on with a different GUID, it just switched modes automatically.

In 3.5, this is not the case, and if you are uploading an update to an existing add-on with a different GUID, you are told that the GUID doesn't match. In order to upload that new GUID, you have to explicitly go to the Submit New Add-on page and go through an intro and developer agreement that should make it pretty clear to anyone that you're about to submit a brand new add-on.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of error message: same add-on, different GUID

fligtar: that's the correct error message, right?

https://bugzilla.mozilla.org/show_bug.cgi?id=282144#c7 states that it'll say the GUIDs "don't match", but this message just notes that it's invalid.

Still, verified FIXED?

Comment 9

[Justin Scott [:fligtar]]

Not the right message. That means your GUID isn't properly formatted. Looks like it might be missing { }

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Yeah, sorry; here we go:

https://remora-3.5.php5stage.mozilla.com/en-US/developers/versions/add/7522

"Oops! There seems to be a problem with this file...

The add-on GUID used in this file ({4fd24fd7-d31f-4a87-a001-cc1a5f72aa26}) does not match the existing GUID for this add-on ([e-mail]).

Please correct this problem and upload your file again."

Verified FIXED