282164 - Deleting last message doesn't reset message pane and window title

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050212] (nightly) (W98SE)

This has been around for a long time...

0. Have a folder with only one message
1. Click on the folder in the folder pane
2. Ctrl-A to select the message
3. Del to delete the message

Comment 1

[Serge Gautherie (:sgautherie)]

This looks very much as bug 58783 was.

"Workaround" is to select another folder afterwards...

Yet it's confusing somehow !

Comment 2

[Mike Cowperthwaite]

I'll bet this is caused by the same problem behind bug 192870, and that it's 
actually a backend (Core) issue -- see TB bug 218779.

Comment 3

[Asa Dotzler [:asa]]

Can someone identify a regression window and pin this one down so we can get it
correctly assigned?

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> I'll bet this is caused by the same problem behind bug 192870, and that it's 

Could be, yes.

> actually a backend (Core) issue -- see TB bug 218779.

Same steps !

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Can someone identify a regression window and pin this one down so we can get it
> correctly assigned?

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.5) Gecko/20041217] (release) (W98SE)

Already there in v1.7.5.

This could be a regression ... yet I don't remember ... I'll try a few
_archived_ builds...

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> This could be a regression ... yet I don't remember ... I'll try a few
> _archived_ builds...

This would not look like a regression, from the few checks I did:

From <http://archive.mozilla.org/pub/mozilla/releases/>

[] (<-- 1.0rc3 !) (W98SE)

(Ctrl-A from folder pane is disabled :-()

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.2a) Gecko/20020910] (W98SE)

Same bug.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.2b) Gecko/20021016] (W98SE)

(MailNews is unusable with my profil, and crashes on exit.)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4) Gecko/20030624] (<-- 1.4rc3 !)
(W98SE)

Same bug.


The bad trick is using Ctrl-A from the folder pane,
rather than clicking directly on the message in the header pane first, which
works...

Comment 7

[[e-mail]]

OK, so what seems to happen here is that a select all of one message will select
it without making it current which confuses the selection code into loading the
message and the deletion code into thinking that you're doing a context delete
which doesn't unload the message.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

If this is a backend issue, there should be a single bug in one of the mailnews
components in the Core product, no?

In any case, too late for 1.8b1; transferring nomination to 1.8b2.

Comment 9

[Mark Banner (:standard8)]

Attachment: Possible patch

This patch fixes both this and the thunderbird one (bug 218779).

The reasoning behind it is that currentIndex may be -1 if a range is selected -
that then causes isSelected to fail. Changing the check to see if anything is
selected causes the function to work correctly.

I have tested it deleting single items, ranges and all within imap, pop, and
local folders.

Comment 10

[[e-mail]]

Ah, but have you tried context-deleting an unselected message? Note that the
selection count is never zero otherwise the delete command would be disabled.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 177283 [details] [diff] [review]
Possible patch

Cancelling review as this doesn't work in the case neil mentioned.

Comment 12

[Robert Kaiser]

This might be confusing, but it's not blocking us from doing an alpha release of
the new suite project.

Comment 13

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050401] (nightly) (W98SE)

This happens when removing a newsgroup too:
(my case)

1. View an article in a newsgroup with 1 article only.
2. Click on left tree to remove the newsgroup.

R. Thread pane is blanked, but title and message pane remain.

Comment 15

[Thomas D. (:thomas8)]

(In reply to [e-mail] from comment #10)
> Ah, but have you tried context-deleting an unselected message? Note that the
> selection count is never zero otherwise the delete command would be disabled.

worksforme on winXP, both TB 17 and Trunk

Using STR from comment 0:
- select folder with only 1 msg in folder pane
- ctrl+a to select the single msg
- DEL to delete it
-> gone without trace in msg reader

even trying to "context-delete an unselected msg" per Neil's comment 10, I can't get into a state where deleted msg is still shown.

Neil, can you still reproduce this?
If not, this bug should be closed wfm

Comment 16

[Thomas D. (:thomas8)]

(In reply to Thomas D. from comment #15)
> Neil, can you still reproduce this?
> If not, this bug should be closed wfm

I'm on POP, so probably somebody should test on IMAP, too.

Comment 17

[Thomas D. (:thomas8)]

Note that this bug is reported against SeaMonkey and I only tested on TB.

Comment 18

[[e-mail]]

(In reply to Thomas from comment #15)
> (In reply comment #10)
> > Ah, but have you tried context-deleting an unselected message? Note that the
> > selection count is never zero otherwise the delete command would be disabled.
> 
> worksforme on winXP, both TB 17 and Trunk

Unless I've misunderstood your reason for quoting my comment, it's not relevant here, just that the patch given would have broken that use case.

Comment 19

[Thomas D. (:thomas8)]

(In reply to [e-mail] from comment #18)
> Unless I've misunderstood your reason for quoting my comment, it's not
> relevant here, just that the patch given would have broken that use case.

Well, it seems that some other patch from some other bug has fixed the problem, so I just wanted to re-test "your" usecase and confirm that the other patch hasn't broken "your" use case, point being I'm not sure if I'm doing your usecase right because if the message is unselected, it will not be displayed to begin with, so it can't disappear as described in this bug.

So can we close this bug wfm for SeaMonkey, too?

Comment 20

[Thomas D. (:thomas8)]

(In reply to Thomas D. from comment #19)
> (In reply to [e-mail] from comment #18)
> > Unless I've misunderstood your reason for quoting my comment, it's not
> > relevant here, just that the patch given would have broken that use case.
> 
> Well, it seems that some other patch from some other bug has fixed the
> problem, so I just wanted

just wanted *you* to retest...

> to re-test "your" usecase and confirm that the
> other patch hasn't broken "your" use case, point being I'm not sure if I'm
> doing your usecase right because if the message is unselected, it will not
> be displayed to begin with, so it can't disappear as described in this bug.
> 
> So can we close this bug wfm for SeaMonkey, too?

Comment 21

[[e-mail]]

Given the age of this bug, my guess as to what "fixed" it was the switch to toolkit widgets. In particular, the toolkit tree ensures that at least one row is current when it is focused (the XPFE tree did not). This means that the code that determines what to do when a row is deleted now sees that the current row was deleted and that it needs to update the message pane.

I don't really like that auto-current behaviour but we're stuck with it, so I guess WFM is the best available resolution. (SeaMonkey uses focusring="true" to indicate thread pane focus so it doesn't need auto-current focus.)